[release/6.0] Skip allocation for ZeroInit writeThru intervals #58767
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ghost
added
the
area-CodeGen-coreclr
|
Tagging subscribers to this area: @JulieLeeMSFT Issue DetailsBackport of #58677 to release/6.0 /cc @kunalspathak Customer ImpactTestingRisk
|
|
@dotnet/jit-contrib |
|
CC @AndyAyersMS for code review for RC2. |
AndyAyersMS
approved these changes
Sep 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58677 to release/6.0
/cc @kunalspathak
Customer Impact
The problem was reported by a customer in #58539 where crossgen2 fails to run on Lucene.Net nuget package.
Testing
Local testing was done for the scenario that customer provided.
Risk
This is a low risk change because we will not allocate register in a rare situation - 1st refposition which needs zero initialization and whose interval is EH write-thru. On subsequent definition refposition, we will allocate the register.