[release/6.0] [MonoVM] Report original DLL name when P/Invoke lookup fails #58863
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
github-actions
bot
requested review from
lambdageek,
thaystg and
vargaz
as code owners
ghost
added
the
|
Tagging subscribers to this area: Issue DetailsBackport of #58206 to release/6.0 Customer ImpactTestingRisk
|
marek-safar
approved these changes
Sep 9, 2021
lambdageek
approved these changes
Sep 9, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #58206 to release/6.0
/cc @akoeplinger @filipnavara
Customer Impact
Without this PR when a P/Invoke lookup fails we'll return an exception message that refers to
libcoreclrinstead of the real native library name since we have logic to retry the lookup using libcoreclr. This is very confusing for customers as can be seen in #58185.Testing
Manual testing.
Risk
Low.