Use caching ConsoleStream for both iOS and Android #58967
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Expands on dotnet#56713 by moving the caching implementation to a separate internal class leaving only the interop calls in ConsolePal.iOS and ConsolePal.Android Fixes dotnet#57304
|
Tagging subscribers to this area: @dotnet/area-system-console |
steveisok
requested review from
adamsitnik,
akoeplinger,
mdh1418 and
stephentoub
filipnavara
approved these changes
Sep 11, 2021
marek-safar
approved these changes
Sep 13, 2021
src/libraries/System.Console/src/System/IO/CachedConsoleStream.cs
Outdated
Show resolved
Hide resolved
|
Failures are unrelated. Timing out most likely due to https://github.com/dotnet/core-eng/issues/14346 |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1233898126 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands on #56713 by moving the caching implementation to a separate internal class and leaving only the interop calls in ConsolePal.iOS and ConsolePal.Android.
Fixes #57304