[release/6.0] [mono] Update attribute name used for controlling frame pointer elimination #59091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
…nation LLVM 8 introduced `"frame-pointer"="all"` as a substitute for `"no-frame-pointer-elim"="true"`. LLVM 10 outright removed `"no-frame-pointer-elim"`.
github-actions
bot
requested review from
EgorBo,
imhameed and
vargaz
as code owners
ghost
added
the
marek-safar
approved these changes
Sep 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59069 to release/6.0
/cc @imhameed
Customer Impact
Minimal. Code generated by LLVM will have elided frame pointers, regardless of if
--disable_omit_fpwas passed to Mono.Testing
CI. Hand-validated that the IR is correct.
Risk
Minimal.