Skip to content

Conversation

vitek-karas
Copy link
Member

On non-Windows we used install_location file with multiple lines which contained locations per-architecture (and the default).

This changes the host to use separate file for each architecture:

  • install_location_<arch> for the architecture specific
  • install_location for the "legacy" file

This is a much easier format for installers to handle (and it also simplifies the apphost code a little bit).

Adapted tests to the new behavior. Removed some tests which don't make sense anymore. Some small test cleanup to deduplicate code.

Changed the test-only env. variable to point to the directory with configuration files instead of to the configuration file itself.

On non-Windows we used install_location file with multiple lines which contained locations per-architecture (and the default).

This changes the host to use separate file for each architecture:
* `install_location.<arch>` for the architecture specific
* `install_location` for the "legacy" file
@vitek-karas vitek-karas added this to the 6.0.0 milestone Sep 21, 2021
@vitek-karas vitek-karas self-assigned this Sep 21, 2021
@ghost
Copy link

ghost commented Sep 21, 2021

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

On non-Windows we used install_location file with multiple lines which contained locations per-architecture (and the default).

This changes the host to use separate file for each architecture:

  • install_location_<arch> for the architecture specific
  • install_location for the "legacy" file

This is a much easier format for installers to handle (and it also simplifies the apphost code a little bit).

Adapted tests to the new behavior. Removed some tests which don't make sense anymore. Some small test cleanup to deduplicate code.

Changed the test-only env. variable to point to the directory with configuration files instead of to the configuration file itself.

Author: vitek-karas
Assignees: vitek-karas
Labels:

area-Host

Milestone: 6.0.0

@vitek-karas
Copy link
Member Author

@richlander @ericstj @agocke

@vitek-karas
Copy link
Member Author

The relevant design doc is being updated in dotnet/designs#248.

@vitek-karas vitek-karas merged commit 072cbae into dotnet:main Sep 22, 2021
@vitek-karas vitek-karas deleted the InstallLocationPerFile branch September 22, 2021 17:04
ericstj pushed a commit to ericstj/runtime that referenced this pull request Sep 22, 2021
On non-Windows we used install_location file with multiple lines which contained locations per-architecture (and the default).

This changes the host to use separate file for each architecture:
* `install_location_<arch>` for the architecture specific
* `install_location` for the "legacy" file

This is a much easier format for installers to handle (and it also simplifies the apphost code a little bit).

Adapted tests to the new behavior. Removed some tests which don't make sense anymore. Some small test cleanup to deduplicate code.

Changed the test-only env. variable to point to the directory with configuration files instead of to the configuration file itself.
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants