Skip to content

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Sep 23, 2021

Backport of #59480 to release/6.0-rc2

/cc @thaystg

Customer Impact

Reuse the buffer will speed up the debugger experience avoiding allocate and deallocate.

Testing

Ran the unit tests

Risk

No risk, it's reusing buffer as it was doing before, but it's correctly allocating a buffer to reuse.

@ghost
Copy link

ghost commented Sep 23, 2021

Tagging subscribers to this area: @thaystg
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #59480 to release/6.0-rc2

/cc @thaystg

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

area-Debugger-mono

Milestone: -

@thaystg thaystg added Servicing-consider Issue for next servicing release review arch-wasm WebAssembly architecture labels Sep 23, 2021
@ghost
Copy link

ghost commented Sep 23, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Backport of #59480 to release/6.0-rc2

/cc @thaystg

Customer Impact

Testing

Risk

Author: github-actions[bot]
Assignees: -
Labels:

Servicing-consider, arch-wasm, area-Debugger-mono

Milestone: -

@lewing
Copy link
Member

lewing commented Sep 23, 2021

runtime (Installer Build and Test coreclr Linux_musl_x64 Release) failed with

Error message
System.ComponentModel.Win32Exception : An error occurred trying to start process '/root/runtime/artifacts/tests/Release/ahb/bphyjj5o.55o/StandaloneApp/publish/StandaloneApp' with working directory '/root/runtime/artifacts/bin/AppHost.Bundle.Tests/Release/net6.0'. Text file busy


Stack trace
   at System.Diagnostics.Process.ForkAndExecProcess(ProcessStartInfo startInfo, String resolvedFilename, String[] argv, String[] envp, String cwd, Boolean setCredentials, UInt32 userId, UInt32 groupId, UInt32[] groups, Int32& stdinFd, Int32& stdoutFd, Int32& stderrFd, Boolean usesTerminal, Boolean throwOnNoExec)
   at System.Diagnostics.Process.StartCore(ProcessStartInfo startInfo)
   at System.Diagnostics.Process.Start()
   at Microsoft.DotNet.Cli.Build.Framework.Command.Start() in /_/src/installer/tests/TestUtils/Command.cs:line 199
   at Microsoft.DotNet.Cli.Build.Framework.Command.Execute(Boolean fExpectedToFail) in /_/src/installer/tests/TestUtils/Command.cs:line 239
   at Microsoft.DotNet.Cli.Build.Framework.Command.Execute() in /_/src/installer/tests/TestUtils/Command.cs:line 171
   at AppHost.Bundle.Tests.StaticHost.Can_Run_App_With_StatiHost() in /_/src/installer/tests/Microsoft.NET.HostModel.Tests/AppHost.Bundle.Tests/StaticHost.cs:line 27

@thaystg thaystg added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Sep 24, 2021
@thaystg
Copy link
Member

thaystg commented Sep 24, 2021

Approved by email

@Anipik
Copy link
Contributor

Anipik commented Sep 24, 2021

can we get a code review here ?

@Anipik Anipik merged commit 9b3cad0 into release/6.0-rc2 Sep 24, 2021
@akoeplinger akoeplinger deleted the backport/pr-59480-to-release/6.0-rc2 branch October 7, 2021 18:38
@ghost ghost locked as resolved and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Debugger-mono Servicing-approved Approved for servicing release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants