Treat 'abstract' properties the same as 'virtual' for src-gen #59707
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveharter
requested review from
eiriktsarpalis and
layomia
as code owners
|
Tagging subscribers to this area: @eiriktsarpalis, @layomia, @krwq Issue DetailsFixes #58985 for 7.0. Expected to be ported to 6.0.
|
layomia
reviewed
Sep 28, 2021
...ries/System.Text.Json/tests/System.Text.Json.SourceGeneration.Tests/RealWorldContextTests.cs
Outdated
Show resolved
Hide resolved
eiriktsarpalis
approved these changes
Sep 29, 2021
|
Build timeouts not related to this PR. Test failure in collections see #58933 |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1288153740 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #58985 for 7.0.
Expected to be ported to 6.0.