[release/6.0] Revert bind single elements to array in configuration binder #59733
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ghost
added
the
|
Tagging subscribers to this area: @maryamariyan, @safern |
|
I don't think that we (asp.net) would have taken a dependency on this as this was mostly intended for xml config arrays right? |
|
For 7.0 when this is revisited, maybe its worth keeping this behavior off by default and allow opt in via a new https://github.com/dotnet/runtime/blob/cb042669bcc1b52be8444e5b865588117310edf1/src/libraries/Microsoft.Extensions.Configuration.Binder/src/BinderOptions.cs property, since the binder definitely tends to have a lot of side effects customers might be relying on |
|
That was the original proposal, however on API Review it was rejected for the reasons described here: #57325 (comment) And yes this was intended for xml arrays that have a single element, because on xml there is no way to express a single item belongs to an array as there is on json or other object notations. |
I don't think there are any new major dependencies on this code yet. We have been validating these changes internally but not have taken a full dependency. |
Yes this is a literal revert of both commits. |
|
@Anipik @danmoseley can I just merge this? |
5 participants
Backport of #59716 to release/6.0
/cc @safern
Customer Impact
When we added this support on RC1 we accidentally introduced to bugs which are breaking costumers:
#58852
#58330
Since we are late on the release cycle I think it is better to revert a late change into the release where the costumer requesting the feature hasn't taken a dependency on it rather than trying to fix the bugs and introducing more risk. We can then do this feature on 7.0 considering the bugs that where reported.
Risk
It is a direct revert, so this goes back to how the product was prior to RC1.