Fix issue with incorrect handling of optimized method layouts #59781
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The sort order of the RuntimeFunctions table (among others) was not properly handled when an optimized method layout was applied - While this bug applied to non-composite builds, it was easily reproduced with a composite build - Fix lack of test infrastructure around non-standard method layouts. - Add new random method sorting order - Use new random sorting order in crossgen2 test passes Fixes dotnet#59089
ghost
added
the
|
@dotnet/crossgen-contrib |
davidfowl
reviewed
Oct 3, 2021
| #endif | ||
| return nodeComparerResult; | ||
| }; | ||
| Comparison<IMethodNode> sortHelperNoCustomSort = (x, y) => comparer.Compare(x, y); |
There was a problem hiding this comment.
Suggested change
| Comparison<IMethodNode> sortHelperNoCustomSort = (x, y) => comparer.Compare(x, y); | |
| Comparison<IMethodNode> sortHelperNoCustomSort = comparer.Compare; |
Less closures?
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1314579960 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #59089