Skip to content

Conversation

MichaelSimons
Copy link
Member

This fixes the underlying issue that manifested itself as #58800.

The core issue is that when building in source-build, the SystemReflectionMetadataVersion gets overridden to the source-built version (6.0) which causes assembly resolution issues impacting crossgen2. The long term solution is a 7.0 source-build feature which would eliminate the SystemReflectionMetadataVersion override because the dependency is not defined in the repo's Version.Details.xml file.

@MichaelSimons
Copy link
Member Author

cc @dseefeld

@ghost
Copy link

ghost commented Sep 29, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

This fixes the underlying issue that manifested itself as #58800.

The core issue is that when building in source-build, the SystemReflectionMetadataVersion gets overridden to the source-built version (6.0) which causes assembly resolution issues impacting crossgen2. The long term solution is a 7.0 source-build feature which would eliminate the SystemReflectionMetadataVersion override because the dependency is not defined in the repo's Version.Details.xml file.

Author: MichaelSimons
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@MichaelSimons
Copy link
Member Author

@ViktorHofer - Can you tell me what ask/tell mode policies apply to this change? Thanks.

@ViktorHofer ViktorHofer changed the title Define SystemReflectionMetadataStaticVersion to prevent source-build from building w/6.0 version. [release/6.0] Define SystemReflectionMetadataStaticVersion to prevent source-build from building w/6.0 version. Sep 30, 2021
@ViktorHofer
Copy link
Member

I'm not sure myself as this is a necessary change to ship .NET 6 built from source. @danmoseley would you know?

@danmoseley
Copy link
Member

"Necessary infra changes to ship" is tell mode to tactics

@MichaelSimons MichaelSimons changed the title [release/6.0] Define SystemReflectionMetadataStaticVersion to prevent source-build from building w/6.0 version. [release/6.0] Define SystemReflectionMetadataStaticVersion to get source-build building. Sep 30, 2021
@MichaelSimons MichaelSimons changed the title [release/6.0] Define SystemReflectionMetadataStaticVersion to get source-build building. [release/6.0] Define SystemReflectionMetadataStaticVersion to workaround source-build issues. Sep 30, 2021
@Anipik Anipik merged commit 23a5153 into dotnet:release/6.0 Sep 30, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants