Do not flush serializer buffers before first IAsyncEnumerable element is fetched #59808
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsAddresses dotnet/aspnetcore#36977 See dotnet/aspnetcore#36977 (comment) for an explanation of the issue. Should consider servicing in 6.0
|
|
Nice. FYI @BrennanConroy since this would resolve the IAsyncEnumerable issue. |
halter73
approved these changes
Sep 30, 2021
krwq
reviewed
Oct 1, 2021
...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs
Show resolved
Hide resolved
krwq
reviewed
Oct 1, 2021
src/libraries/System.Text.Json/tests/Common/CollectionTests/CollectionTests.AsyncEnumerable.cs
Show resolved
Hide resolved
steveharter
reviewed
Oct 1, 2021
...son/src/System/Text/Json/Serialization/Converters/Collection/IAsyncEnumerableOfTConverter.cs
Show resolved
Hide resolved
steveharter
reviewed
Oct 1, 2021
...libraries/System.Text.Json/src/System/Text/Json/Serialization/JsonSerializer.Write.Stream.cs
Show resolved
Hide resolved
steveharter
approved these changes
Oct 1, 2021
ericstj
approved these changes
Oct 1, 2021
|
|
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1295615263 |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses dotnet/aspnetcore#36977
See dotnet/aspnetcore#36977 (comment) for an explanation of the issue.
I ran the benchmark suite against the changes and no performance regression was recorded.
Should consider servicing in 6.0.