Skip to content

Update workload localization file directory structure #59827

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 4, 2021
Merged

Update workload localization file directory structure #59827

merged 1 commit into from
Oct 4, 2021

Conversation

sfoslund
Copy link
Member

@sfoslund sfoslund commented Sep 30, 2021 •
edited
Loading

Fixing a bug in #59379, part of dotnet/sdk#20497

Workload/SDK logic only copies content in the data directory, so moving the localize directory into the proper location to be picked up and laid down on disk.

@ghost ghost added the area-System.Net label Sep 30, 2021
@ghost
Copy link

ghost commented Sep 30, 2021

Tagging subscribers to this area: @dotnet/ncl
See info in area-owners.md if you want to be subscribed.

Issue Details

null

Author: sfoslund
Assignees: -
Labels:

area-System.Net
Milestone: -

@sfoslund sfoslund requested review from joeloff, lewing and wli3 September 30, 2021 20:34
@sfoslund
Copy link
Member Author

@marek-safar is this the correct branch for 6.0 GA?

@marek-safar
Copy link
Contributor

is this the correct branch for 6.0 GA?

Yes but the better way is to land it to main first with automatic backport

@marek-safar marek-safar added the Servicing-consider Issue for next servicing release review label Oct 1, 2021
@sfoslund
Copy link
Member Author

sfoslund commented Oct 1, 2021

Yes but the better way is to land it to main first with automatic backport

It looks like the original change I'm working off of is not in main yet, so I'll cherry pick these changes into main in a separate PR.

@sfoslund
Copy link
Member Author

sfoslund commented Oct 1, 2021

@joeloff @steveisok @lewing can I get a review here so I can send a QB approval request?

@sfoslund
Copy link
Member Author

sfoslund commented Oct 1, 2021

Thanks!

@steveisok
Copy link
Member

Please cherry pick the localization changes to main in the follow up PR.

@sfoslund
Copy link
Member Author

sfoslund commented Oct 1, 2021

Follow up PR into main: #59872

@sfoslund
Copy link
Member Author

sfoslund commented Oct 4, 2021

@steveisok this has been approved but I don't have permissions to merge, can you please merge?

@steveisok steveisok added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Oct 4, 2021
@steveisok steveisok merged commit 8a75ba0 into release/6.0 Oct 4, 2021
@sfoslund sfoslund deleted the UpdateWorkloadLocAuthoring branch October 4, 2021 16:08
@karelz karelz added this to the 6.0.0 milestone Oct 14, 2021
@ghost ghost locked as resolved and limited conversation to collaborators Nov 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@steveisok steveisok steveisok approved these changes

@joeloff joeloff joeloff approved these changes

@marek-safar marek-safar Awaiting requested review from marek-safar marek-safar is a code owner

@lewing lewing Awaiting requested review from lewing

@wli3 wli3 Awaiting requested review from wli3

Assignees

No one assigned

Labels

area-Infrastructure-mono Servicing-approved Approved for servicing release

Projects

None yet

Milestone

6.0.0

Development

Successfully merging this pull request may close these issues.

5 participants

@sfoslund @marek-safar @steveisok @joeloff @karelz