[release/6.0] Produce symbols archives #59843
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
Contributes to #49026
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
hoyosjs
approved these changes
Sep 30, 2021
jkoritzinsky
added
area-Setup
source-build
jeffschwMSFT
approved these changes
Sep 30, 2021
There was a problem hiding this comment.
Approved. As this is an infra change we can take this as tell mode. Once it is green, @Anipik can you help merging this?
MichaelSimons
approved these changes
Oct 1, 2021
|
@Anipik, can this get merged? |
|
I need to make a small change to this PR to avoid breaking the official build. |
jkoritzinsky
added
the
NO-MERGE
… the official build.
|
I've ported back my official build fix. This is ready for merge again. |
jkoritzinsky
removed
the
NO-MERGE
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59842 to release/6.0
/cc @jkoritzinsky
Customer Impact
This PR re-enables publishing the symbols archives, which are required for source-build. This fixes dotnet/source-build#2403, which is currently blocking 6.0 source build.
Testing
Local validation that the archives are produced.
Risk
Minimal risk. This only produces an additional output file with a well known name that is shipped as a separate file to the blob feed. It does not affect any other files we are shipping.