[release/6.0] Fix incorrect tracking of sign bit in BigInteger #59951
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
ghost
added
the
|
Tagging subscribers to this area: @dotnet/area-system-numerics Issue DetailsBackport of #59525 to release/6.0 Customer ImpactTestingRisk
|
|
CC. @jeffhandley |
jeffhandley
changed the title
|
approved in email |
|
can somebody review this one ? |
danmoseley
added
Servicing-approved
jeffhandley
approved these changes
Oct 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59525 to release/6.0.
Issue: #59509 - Right shift of specific BigInteger values is producing incorrect results
/cc @tannergooding @wzchua
Customer Impact
Right shifting of certain
BigIntegervalues resulted in incorrect results. This was reported and diagnosed by a customer and fixed by a frequent external contributor.Regression
Yes. This is a regression from .NET Framework, .NET Core, and .NET 5.
Testing
Additional test coverage was added for the found regression.
Risk
Low due to additional test coverage that now exists.