Avoid resetting gen0 bricks for background_sweep (#59106) #59960
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Tagging subscribers to this area: @dotnet/gc Issue Detailsnull
|
jeffschwMSFT
approved these changes
Oct 5, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting #59106
Customer Impact
Exchange reported that they are hitting occasionally long gen 1 GC that hurts their tail latencies, having this change available in .NET 6 will allow them to have the fix right away once they upgrade to .NET 6.
They used to be able to reproduce this occasionally long GC in around 20 minutes, with the fix, they don’t detect that anymore in 6 hours.
Testing
This change went through 48 hours of stress testing on both workstation and server GC, and also many runs on the Exchange perf tests.
Risk
Low – given we have done a lot of testing.