[release/6.0] Update THIRD-PARTY-NOTICES.TXT #60092

NikolaMilosavljevic · 2021-10-06T21:29:47Z

Update third-party-notices file for .NET 6.

Infra used to generate this file is in another PR: #60091

Here's the output of TPN regeneration process, specifying which repo contributes each new notice:

  New section to import: 'License notice for Angular v8.0  --------------------------------------------  The MIT License (MIT)' of https://github.com/raw/dotnet/aspnetcore/master/THIRD-PARTY-NOTICES.txt line 167
  New section to import: 'License notice for JavaScript queues' of https://github.com/raw/dotnet/runtime/master/THIRD-PARTY-NOTICES.TXT line 974
  New section to import: 'License notice for MSBuild Locator' of https://github.com/raw/dotnet/roslyn-analyzers/master/THIRD-PARTY-NOTICES.txt line 11
  New section to import: 'License notice for Newtonsoft.Json' of https://github.com/raw/dotnet/aspnetcore/master/THIRD-PARTY-NOTICES.txt line 322
  New section to import: 'License notice for NuGet.Client' of https://github.com/raw/dotnet/templating/master/THIRD-PARTY-NOTICES line 10
  New section to import: 'License notice for Roslyn Clr Heap Allocation Analyzer' of https://github.com/raw/dotnet/roslyn-analyzers/master/THIRD-PARTY-NOTICES.txt line 28
  New section to import: 'License notice for StyleCop Analyzers' of https://github.com/raw/dotnet/roslyn-analyzers/master/THIRD-PARTY-NOTICES.txt line 42
  New section to import: 'The MIT License (MIT)' of https://github.com/raw/dotnet/aspnetcore/master/THIRD-PARTY-NOTICES.txt line 194
  Importing 9 sections...

joeloff · 2021-10-06T22:59:00Z

Question... Visual Studio has a massive TPN. In the past it's something that's been updated whenever an external component like .NET is added to VS. jQuery and Bootstrap comes to mind for ASP.NET. Should we include the changes to our TPN in the VS TPN as well?

NikolaMilosavljevic · 2021-10-07T15:11:10Z

Updated the TPN to incorporate formatting/sorting changes due to updates in infra: a945962

Output of the tool:

  New section to import: 'License for fastmod (https://github.com/lemire/fastmod) and ibm-fpgen (https://github.com/nigeltao/parse-number-fxx-test-data)' of https://github.com/raw/dotnet/runtime/main/THIRD-PARTY-NOTICES.TXT line 682
  New section to import: 'License notice for Angular v8.0  --------------------------------------------  The MIT License (MIT)' of https://github.com/raw/dotnet/aspnetcore/main/THIRD-PARTY-NOTICES.txt line 167
  New section to import: 'License notice for JavaScript queues' of https://github.com/raw/dotnet/runtime/main/THIRD-PARTY-NOTICES.TXT line 974
  New section to import: 'License notice for MSBuild Locator' of https://github.com/raw/dotnet/roslyn-analyzers/main/THIRD-PARTY-NOTICES.txt line 11
  New section to import: 'License notice for Newtonsoft.Json' of https://github.com/raw/dotnet/aspnetcore/main/THIRD-PARTY-NOTICES.txt line 322
  New section to import: 'License notice for NuGet.Client' of https://github.com/raw/dotnet/templating/main/THIRD-PARTY-NOTICES line 10
  New section to import: 'License notice for Roslyn Clr Heap Allocation Analyzer' of https://github.com/raw/dotnet/roslyn-analyzers/main/THIRD-PARTY-NOTICES.txt line 28
  New section to import: 'License notice for StyleCop Analyzers' of https://github.com/raw/dotnet/roslyn-analyzers/main/THIRD-PARTY-NOTICES.txt line 42
  New section to import: 'The MIT License (MIT)' of https://github.com/raw/dotnet/aspnetcore/main/THIRD-PARTY-NOTICES.txt line 194
  Importing 9 sections...

sharwell · 2021-10-07T15:16:23Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

+
+------------------------------------------------
+
+The MIT License (MIT)


❔ Which one is this associated with?

This is coming from dotnet/aspnetcore/main/THIRD-PARTY-NOTICES.txt line 194

https://github.com/dotnet/aspnetcore/blob/main/THIRD-PARTY-NOTICES.txt line 194 is blank and I suspect this should be under the License notice for corefx title above. See https://github.com/dotnet/runtime/pull/60092/files#diff-1f7876cafb24ce314004bb439a08320edba033f8a8a43d1961009f1088bd43d3R1350

sharwell · 2021-10-07T15:17:32Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

+
+Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.
+
+License notice for StyleCop Analyzers


💭 While I have no objection to seeing this here, does it apply for cases where the referenced package is only a development dependency?

💭 While I have no objection to seeing this here, does it apply for cases where the referenced package is only a development dependency?

Good question - I'm not sure, but it would be easy to remove this one.

@richlander do we need to include dev-time dependencies in our shipping TPN? Presumably not.

hoyosjs

LGTM other than the comment from Sam, where it's not clear what the last license is for.

danmoseley · 2021-10-13T00:47:51Z

@NikolaMilosavljevic is this mergeable?

NikolaMilosavljevic · 2021-10-13T00:56:39Z

@NikolaMilosavljevic is this mergeable?

Quite a few reviews are missing, but otherwise it's mergeable.

Anipik · 2021-10-13T05:49:01Z

@NikolaMilosavljevic can you tag the reviewers again ? (which are required for the final merge)

NikolaMilosavljevic · 2021-10-13T16:36:45Z

@mkArtakMSFT , @dougbu - we are missing aspnetcore sign-off - can you review new entries coming from dotnet/aspnetcore?

NikolaMilosavljevic · 2021-10-13T16:37:24Z

@NikolaMilosavljevic can you tag the reviewers again ? (which are required for the final merge)

aspnetcore is the only one missing - I've added and tagged more reviewers for that repo.

dougbu

I don't know exactly how or why some of these items are used and probably shouldn't be the approver. @mkArtakMSFT who else needs to look at this❔

dougbu · 2021-10-13T17:52:15Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

+
+------------------------------------------------
+
+The MIT License (MIT)


https://github.com/dotnet/aspnetcore/blob/main/THIRD-PARTY-NOTICES.txt line 194 is blank and I suspect this should be under the License notice for corefx title above. See https://github.com/dotnet/runtime/pull/60092/files#diff-1f7876cafb24ce314004bb439a08320edba033f8a8a43d1961009f1088bd43d3R1350

dougbu · 2021-10-13T18:30:16Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

 OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
 SOFTWARE.

+License notice for musl


This may also be a dev / build dependency. We build (an installer?) for Linux MUSL on an Alpine image but I'm not sure exactly how that uses MUSL libraries.

Fixed the empty line and moved under corefx.

@NikolaMilosavljevic was this a response to https://github.com/dotnet/runtime/pull/60092#discussion_r728315386❔

@NikolaMilosavljevic was this a response to https://github.com/dotnet/runtime/pull/60092#discussion_r728315386❔

Yes, that is correct - fixing the issue above. There was no way to add a comment right underneath that issue.

musl gets compiled into every WebAssembly app via emscripten. We should probably mention emscripten too /cc @lewing

dougbu · 2021-10-13T18:31:06Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

+
 License notice for Angular v8.0
--------------------------------------------
+--------------------------------


Add a blank line after this for consistency

This is coming from dotnet/aspnetcore - we could fix it here, but it should also be fixed in source location to not regress in the future.

dougbu · 2021-10-13T18:31:40Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

+   limitations under the License.
+
+License notice for Angular v8.0
+--------------------------------------------


Shorten and add a blank line after this

Fixed - also removed duplicate 'Angular 8.0' notice.

dougbu · 2021-10-13T18:31:53Z

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
+THE SOFTWARE.
+
+License notice for corefx


This is a dangling header

Fixed - removed.

dougbu · 2021-10-13T18:36:01Z

Side question: Why do you need ASP.NET sign-off on a Runtime PR❔ Is this TPN.txt file going to be used for every published asset from any repo❔

NikolaMilosavljevic · 2021-10-13T18:37:31Z

Side question: Why do you need ASP.NET sign-off on a Runtime PR❔ Is this TPN.txt file going to be used for every published asset from any repo❔

Yes, this is a merged TPN, that is installed under dotnet folder - it covers everything we install there, including ASP.NET.

NikolaMilosavljevic · 2021-10-18T15:51:09Z

@dougbu changes requested in your review were implemented and pushed on Friday. Can you approve for aspnetcore, or do we need someone else to do it? This is the last approval before we merge, and we'd prefer to not wait any longer.

@Anipik - fyi

mkArtakMSFT · 2021-10-18T18:42:01Z

Side question: Why do you need ASP.NET sign-off on a Runtime PR❔ Is this TPN.txt file going to be used for every published asset from any repo❔

Yes, this is a merged TPN, that is installed under dotnet folder - it covers everything we install there, including ASP.NET.

@NikolaMilosavljevic, given that's the case, what about all the other dependencies that ASP.NET Core has? Shouldn't these also be listed here?

NikolaMilosavljevic · 2021-10-18T18:46:35Z

Side question: Why do you need ASP.NET sign-off on a Runtime PR❔ Is this TPN.txt file going to be used for every published asset from any repo❔

Yes, this is a merged TPN, that is installed under dotnet folder - it covers everything we install there, including ASP.NET.

@NikolaMilosavljevic, given that's the case, what about all the other dependencies that ASP.NET Core has? Shouldn't these also be listed here?

All ASP.NET dependencies are here, in the shared file. We avoid duplication and only include a single instance of the same dependency. It's likely that many of those dependencies are also present in other repos and included in a different section of this unified file.

Is there a specific dependency of ASP.NET that should be included but it is not present?

Pilchie

This looks fine for aspnetcore. @dougbu is OOF today, so don't feel you have to wait for his sign-off.

src/installer/pkg/THIRD-PARTY-NOTICES.TXT

NikolaMilosavljevic · 2021-10-18T20:19:10Z

Unless I hear objections in the the 15 minutes, I'm going to merge this PR. @Pilchie , @mkArtakMSFT your questions have replies, can you help resolve those concerns (conversations)?

Update THIRD-PARTY-NOTICES.TXT

fe51373

NikolaMilosavljevic requested review from Pilchie, ViktorHofer, agocke, danmoseley, hoyosjs, jaredpar, jeffschwMSFT, jkoritzinsky, jmarolf, joeloff, mavasani, merriemcgaw, pranavkm and ryalanms October 6, 2021 21:29

ghost added the area-Setup label Oct 6, 2021

joeloff approved these changes Oct 6, 2021

View reviewed changes

jmarolf approved these changes Oct 6, 2021

View reviewed changes

Regenerating to incorporate a change in infra

2924664

sharwell reviewed Oct 7, 2021

View reviewed changes

hoyosjs approved these changes Oct 10, 2021

View reviewed changes

ViktorHofer approved these changes Oct 13, 2021

View reviewed changes

NikolaMilosavljevic requested review from dougbu and mkArtakMSFT October 13, 2021 16:35

dougbu reviewed Oct 13, 2021

View reviewed changes

NikolaMilosavljevic added 2 commits October 13, 2021 13:56

Fixes for duplicate instance and misplaced header

5baf9ae

Remove duplicate corefx header

9316650

danmoseley changed the title ~~Update THIRD-PARTY-NOTICES.TXT~~ [release/6.0] Update THIRD-PARTY-NOTICES.TXT Oct 18, 2021

Pilchie reviewed Oct 18, 2021

View reviewed changes

src/installer/pkg/THIRD-PARTY-NOTICES.TXT Show resolved Hide resolved

NikolaMilosavljevic merged commit 5a23dc3 into dotnet:release/6.0 Oct 18, 2021

ghost locked as resolved and limited conversation to collaborators Nov 18, 2021


		------------------------------------------------

		The MIT License (MIT)


		Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the specific language governing permissions and limitations under the License.

		License notice for StyleCop Analyzers

[release/6.0] Update THIRD-PARTY-NOTICES.TXT #60092

[release/6.0] Update THIRD-PARTY-NOTICES.TXT #60092

Uh oh!

Conversation

NikolaMilosavljevic commented Oct 6, 2021

Uh oh!

joeloff commented Oct 6, 2021

Uh oh!

NikolaMilosavljevic commented Oct 7, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

hoyosjs left a comment

Choose a reason for hiding this comment

Uh oh!

danmoseley commented Oct 13, 2021

Uh oh!

NikolaMilosavljevic commented Oct 13, 2021

Uh oh!

Anipik commented Oct 13, 2021

Uh oh!

NikolaMilosavljevic commented Oct 13, 2021

Uh oh!

NikolaMilosavljevic commented Oct 13, 2021

Uh oh!

dougbu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dougbu commented Oct 13, 2021

Uh oh!

NikolaMilosavljevic commented Oct 13, 2021

Uh oh!

NikolaMilosavljevic commented Oct 18, 2021

Uh oh!

mkArtakMSFT commented Oct 18, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

NikolaMilosavljevic commented Oct 18, 2021

Uh oh!

Pilchie left a comment

Choose a reason for hiding this comment

Uh oh!

mkArtakMSFT commented Oct 18, 2021 •

edited

Loading