[release/6.0] Fix issue in decommit_ephemeral_segment_pages (segment case). #60170
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
We assume that we can use half the free list space in gen 0 for new allocation. If that is too optimistic, we may allocate into decommitted memory and crash in the allocator. That is because there is a race condition between the allocating thread and the decommitting thread - we decided to avoid that by making sure we would never decommit memory that we may allocate in gen 0. There are two reasons why assuming we can use half the free list space for new allocations may be too optimistic: - if we allocate large objects in gen 0, we may not have free spaces of the necessary size available. - when background GC goes into background_ephemeral_sweep, it deletes and rebuilds the free list for gen 0. A thread trying to allocate during that time may see a completely empty free list.
jeffschwMSFT
approved these changes
Oct 11, 2021
jeffschwMSFT
added
the
Servicing-consider
mangod9
approved these changes
Oct 11, 2021
Maoni0
approved these changes
Oct 11, 2021
jeffschwMSFT
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #59989 to release/6.0
/cc @PeterSolMS
Customer Impact
This bug may cause random AVs and memory corruption. The root cause is a race condition between user threads allocating and GC thread 0 decommitting memory.
Testing
Ran GC stress test overnight with no issues.
Risk
Low. The bug crept in because of a change I made for regions that was too agressive. The proposed fix essentially goes back to the code before that change, which is what we shipped in 5.0.