Skip to content

Conversation

steveisok
Copy link
Member

Replaces GenerateVersions that wasn't quite accurate enough for what we need

Replaces GenerateVersions that wasn't quite accurate enough for what we need
@ghost
Copy link

ghost commented Oct 19, 2021

Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer
See info in area-owners.md if you want to be subscribed.

Issue Details

Replaces GenerateVersions that wasn't quite accurate enough for what we need

Author: steveisok
Assignees: -
Labels:

area-Infrastructure-libraries

Milestone: -

@steveisok
Copy link
Member Author

@radical
Copy link
Member

radical commented Oct 20, 2021

re:WasmBuildTests workload installation failure, not sure why exactly it is failing. I have seen that before on windows, but that was when you would have two packs dir with the same name differing only in case. Maybe the tool is getting confused somehow?

Also, note that even after the rollback, there is a /__w/1/s/artifacts/bin/dotnet-workload/packs/Microsoft.NET.Runtime.Emscripten.2.0.23.Sdk.linux-x64 directory left. So, that might be the one for which it got confused, and that tracks with the pack that it failed at.

I'll wait to see if the re-run also fails.

@steveisok
Copy link
Member Author

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1364843150

@github-actions
Copy link
Contributor

@steveisok an error occurred while backporting to release/6.0, please check the run log for details!

Error: @steveisok is not a repo collaborator, backporting is not allowed.

@lewing
Copy link
Member

lewing commented Oct 20, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1364857178

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like what we discussed since using the arcade target was not possible. Should we open an issue in arcade as well.

@steveisok steveisok merged commit e5da901 into dotnet:main Oct 20, 2021
@steveisok steveisok deleted the tweak-workload-version-target branch October 20, 2021 20:26
@ghost ghost locked as resolved and limited conversation to collaborators Nov 20, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants