-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Tweak workload build to use _GenerateMsiVersionString target #60634
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak workload build to use _GenerateMsiVersionString target #60634
Conversation
Replaces GenerateVersions that wasn't quite accurate enough for what we need
Tagging subscribers to this area: @Anipik, @safern, @ViktorHofer Issue DetailsReplaces GenerateVersions that wasn't quite accurate enough for what we need
|
official build successful https://dev.azure.com/dnceng/internal/_build/results?buildId=1430904&view=results |
re:WasmBuildTests workload installation failure, not sure why exactly it is failing. I have seen that before on windows, but that was when you would have two packs dir with the same name differing only in case. Maybe the tool is getting confused somehow? Also, note that even after the rollback, there is a I'll wait to see if the re-run also fails. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1364843150 |
@steveisok an error occurred while backporting to release/6.0, please check the run log for details! Error: @steveisok is not a repo collaborator, backporting is not allowed. |
/backport to release/6.0 |
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1364857178 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like what we discussed since using the arcade target was not possible. Should we open an issue in arcade as well.
Replaces GenerateVersions that wasn't quite accurate enough for what we need