Skip to content

Conversation

annchous
Copy link
Contributor

@annchous annchous commented Nov 8, 2021

Fixes #61282

@annchous annchous marked this pull request as draft November 8, 2021 17:30
@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Nov 8, 2021
@ghost
Copy link

ghost commented Nov 8, 2021

Tagging subscribers to this area: @buyaa-n
See info in area-owners.md if you want to be subscribed.

Issue Details

Close #61282

Author: annchous
Assignees: -
Labels:

area-System.Reflection

Milestone: -

@am11
Copy link
Member

am11 commented Nov 8, 2021

Would be good to have a test like:

[Fact]
public static void Test_CustomAttributeTypedArgument_ToString()
{
    var argument = new CustomAttributeTypedArgument(new [] { new CustomAttributeTypedArgument(0) });

    Assert.Equal("new CustomAttributeTypedArgument[1] { 0 }", argument.ToString());
}

after:

@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 8, 2021

@annchous
Copy link
Contributor Author

annchous commented Nov 8, 2021

@annchous please add unit test in here https://github.com/dotnet/runtime/blob/main/src/libraries/System.Runtime/tests/System/Reflection/CustomAttribute_Named_Typed_ArgumentTests.cs

Yup, I've already found that place, thanks! In process with test now :)

@annchous annchous marked this pull request as ready for review November 8, 2021 17:57
Copy link
Contributor

@buyaa-n buyaa-n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 8, 2021

The build failure unrelated, filed an issue for failure, merging

@buyaa-n buyaa-n merged commit 768f200 into dotnet:main Nov 8, 2021
@buyaa-n
Copy link
Contributor

buyaa-n commented Nov 8, 2021

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Nov 8, 2021

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1437102307

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-System.Reflection community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

CustomAttributeTypedArgument.ToString() is missing an open curly

3 participants