[wasm] [debugger] Eval fixes for static class eval #61660
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…natommy/runtime into add-static-attribute-support
…ts that fail in Consol App.
…chance it will be located out of the current assembly.
…-classes-fix-broken-tests
…n-tests Nested static classes fix broken tests
…tion Fix for 4 failing tests of Count evaluation.
radical
reviewed
Nov 23, 2021
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
src/mono/wasm/debugger/BrowserDebugProxy/MemberReferenceResolver.cs
Outdated
Show resolved
Hide resolved
…er.cs Co-authored-by: Ankit Jain <[email protected]>
…er.cs Co-authored-by: Ankit Jain <[email protected]>
…PR." This reverts commit 6a1b7ad.
…port Add nested static attribute support
|
@radical, as discussed I merged nested static evaluation PR with this one. Only 2 more tests fail on this PR in comparison to main and they are connected with lack of method evaluation without namespace (EvaluateStaticClassFromStaticMethod cannot be found in the same namespace it is declared). It will have to be solved in a separate PR. |
radical
approved these changes
Nov 24, 2021
|
Fixes #61462. |
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Covering skipped evaluation cases from #61252. To be merged after #61252.
It fixes static classes evaluation and nested static classes evaluation. It changed nested classes access concatenation character: from "/" to ".".
Requires a follow-up Issue to fix the test: EvaluateStaticClassFromStaticMethod with parameters without the full namespace.