Add backtracking loops, backreferences, and if-then-else constructs to Regex "simplified" code gen #61906
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @eerhardt, @dotnet/area-system-text-regularexpressions |
10 tasks
joperezr
reviewed
Nov 22, 2021
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 22, 2021
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 22, 2021
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 22, 2021
src/libraries/System.Text.RegularExpressions/tests/Regex.KnownPattern.Tests.cs
Outdated
Show resolved
Hide resolved
joperezr
reviewed
Nov 22, 2021
There was a problem hiding this comment.
mmm interesting, I would have expected this to trigger a linker warning since the place using this is not annotated as RequiresUnreferencedCode cc: @eerhardt
joperezr
approved these changes
Nov 22, 2021
Labels need to be followed by something other than a closing brace. Previously I was trying to opt labels in to emitting a semi-colon, but it's too error prone. Instead, we now by default emit a semicolon, and only skip it from call sites that opt-out because it's obvious they'll always be followed by code.
stephentoub
force-pushed
the
simpleloop
branch
from
835a491 to
6809bb7
Compare
danmoseley
reviewed
Nov 23, 2021
src/libraries/System.Text.RegularExpressions/gen/RegexGenerator.Emitter.cs
Show resolved
Hide resolved
danmoseley
reviewed
Nov 23, 2021
This was referenced Nov 29, 2021
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributes to #61902
Adds support to our "simplified" Regex codegen for backtracking loops, backreferences, and both if-then-else constructs.
cc: @joperezr