Skip to content

Conversation

radical
Copy link
Member

@radical radical commented Nov 22, 2021

@radical radical added arch-wasm WebAssembly architecture area-Build-mono labels Nov 22, 2021
@ghost
Copy link

ghost commented Nov 22, 2021

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details
Author: radical
Assignees: -
Labels:

arch-wasm, area-Build-mono

Milestone: -

@radical radical requested a review from steveisok November 22, 2021 21:11
@radical
Copy link
Member Author

radical commented Nov 22, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@lewing lewing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test exclusions and chrome bump look good, @steveisok can you take a look at the pipeline bits

radical and others added 4 commits November 23, 2021 17:26
`System.Net.WebSockets.Client.Tests`, and
`System.Net.Http.Functional.Tests` fail because the echo servers don't
get included in the helix payload.

 - Don't condition the inclusion on `RunSmokeTestsOnly`, instead it will
   be included only if it was built, and that would depend correctly on
   `RunSmokeTestsOnly`.
- Pass the smoke test argument to the build command line for
  wasm/windows
@radical
Copy link
Member Author

radical commented Nov 23, 2021

/azp run runtime-manual

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Member

@steveisok steveisok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@radical radical merged commit f9dfd41 into dotnet:main Nov 24, 2021
@radical radical deleted the misc-wasm-fixes branch November 24, 2021 01:17
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants