Skip to content

Conversation

adamsitnik
Copy link
Member

fixes #62119

@adamsitnik adamsitnik added this to the 7.0.0 milestone Nov 29, 2021
@ghost
Copy link

ghost commented Nov 29, 2021

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #62119

Author: adamsitnik
Assignees: -
Labels:

area-System.IO

Milestone: 7.0.0

Copy link
Contributor

@carlossanlop carlossanlop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for fixing it.

I wasn't aware that csproj property existed. The only concern I have is if we are making the CI slower now that all test methods from this project will be executed individual instead of parallel. I'd be more inclined on making individual test methods not run in parallel, instead of the whole project. Thoughts?

@adamsitnik
Copy link
Member Author

I wasn't aware that csproj property existed.

Same here, I found it by accident when I was refactoring the code for #62132

I'd be more inclined on making individual test methods not run in parallel, instead of the whole project

I was also concerned about the execution time. Before my change it was taking 0.138s to run the tests on my machine, now it takes0.184s so I think that we are fine. An advantage of having it per entire project is minimizing the risk of adding a new test in the future and forgetting about annotating it.

@carlossanlop
Copy link
Contributor

Ci failure is known and unrelated (#62028):

CSC(0,0): error CS2012: (NETCORE_ENGINEERING_TELEMETRY=Build)
Cannot open
'D:\a\_work\1\s\artifacts\obj\Microsoft.Interop.SourceGeneration\netstandard2.0-Release\Microsoft.Interop.SourceGeneration.dll'
for writing --
'The process cannot access the file
'D:\a\_work\1\s\artifacts\obj\Microsoft.Interop.SourceGeneration\netstandard2.0-Release\Microsoft.Interop.SourceGeneration.dll'
because it is being used by another process.'

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Test failure System.IO.FileSystem.Tests.DriveInfoWindowsTests.TestGetDrives

2 participants