[release/6.0] Fixing a possible null reference error in WebSocket deflate. #62716
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
|
Tagging subscribers to this area: @dotnet/ncl Issue DetailsBackport of #62428 to release/6.0 /cc @CarnaViire @zlatanov Customer ImpactTestingRisk
|
karelz
approved these changes
Dec 13, 2021
CarnaViire
approved these changes
Dec 14, 2021
|
@CarnaViire could you please send mail direct to tactics for approval as I'm on vac from tomorrow. |
|
I will handle the Tactics email. |
leecow
added
Servicing-approved
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #62428 to release/6.0
Fixes #62422
/cc @CarnaViire @zlatanov
Customer Impact
Customer reported segfault crashes after turning on WebSocket compression (new feature in .NET 6.0), which happened 1x per day in their production across multiple servers with 50-100 WebSocket messages per second.
It's a bug where output buffer may unexpectedly become exhausted which would lead to trying to pin an empty span.
Testing
Customer verified the fix using private bits #62422 (comment)
Note: It is hard to generate targeted test that would hit the problem, as the payload needs to be crafted for specific internal zlib buffer size (256KB).
Risk
Low. A one-liner change in product code.
WebSocket compression is a new feature in 6.0 which is turned off by default.