Skip to content

Conversation

safern
Copy link
Member

@safern safern commented Dec 16, 2021

Fixes: #62218

Customer Impact

When doing some refactoring on how we calculate assembly versions we accidentally removed a property that calculated the file version embedded into the assembly. When an application is compiled as self-contained and bundled into an MSI file, upgrading from a previous (e.g. .NET 5) which can lead to this assembly missing on the installation location or the wrong assembly to be used.

Testing

VIsual inspection of the assembly to make sure the file version is correct and higher than the ones in previous releases.

image

Risk

Low, this is just changing the file version embedded into the assembly.

@safern safern requested review from ericstj and joperezr December 16, 2021 16:38
@ghost ghost assigned safern Dec 16, 2021
@ghost
Copy link

ghost commented Dec 16, 2021

Tagging subscribers to this area: @cston
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #62218

Customer Impact

When doing some refactoring on how we calculate assembly versions we accidentally removed a property that calculated the file version embedded into the assembly. When an application is compiled as self-contained and bundled into an MSI file, upgrading from a previous (e.g. .NET 5) which can lead to this assembly missing on the installation location or the wrong assembly to be used.

Testing

VIsual inspection of the assembly to make sure the file version is correct and higher than the ones in previous releases.

image

Risk

Low, this is just changing the file version embedded into the assembly.

Author: safern
Assignees: -
Labels:

area-Microsoft.VisualBasic

Milestone: -

@safern safern added the Servicing-consider Issue for next servicing release review label Dec 16, 2021
@leecow leecow added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Dec 16, 2021
@leecow leecow added this to the 6.0.2 milestone Dec 16, 2021
@safern
Copy link
Member Author

safern commented Dec 16, 2021

Failures are networking tests and a long running test that was moved to outerloop on main already, will port that fix to unblock CI as I've seen it enough times on 6.0

@safern safern merged commit bbd29a6 into dotnet:release/6.0 Dec 16, 2021
@safern safern deleted the VisualBasicFileVersion60 branch December 16, 2021 19:00
@ghost ghost locked as resolved and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants