[release/6.0] Fix NETStandard library using JSON source gen #63520
Conversation
NETStandard libraries using JSON source gen would fail to load on .NETCore due to missing IsExternalInit in the assembly. On .NETCore this is defined, whereas on .NETStandard JSON carries an internal copy. The compiler emits references to the internal type when a NETStandard library calls init-only setters in JSON types, but these references are not satisfied when the library runs on .NETCore. Fix this by adding a type forward to JSON for the IsExternalInit type.
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
ghost
added
|
Tagging subscribers to this area: @dotnet/area-system-text-json Issue DetailsFixes #61737 Customer ImpactCustomers cannot use JSON source generators defined in a TestingAdded tests to catch this scenario. Tests fail without fix, succeed with. Searched repo for any other instances. RiskVery low. We are merely adding a typeforward to System.Text.Json for
|
ericstj
changed the title
ericstj
added
Servicing-approved
|
Approved over email |
|
I don't understand what the issue is? I thought the compiler doesn't care about the type identity of the attribute, only about the name of the applied attribute. What causes this to be an issue during reflection? |
5 participants
Fixes #61737
Customer Impact
Customers cannot use JSON source generators defined in a
netstandardlibrary from anet6.0app. This will fail withMissingMethodException.Testing
Added tests to catch this scenario. Tests fail without fix, succeed with. Searched repo for any other instances.
Risk
Very low. We are merely adding a typeforward to System.Text.Json for
IsExternalInit.