[release/6.0] Fix GENERIC_MATH_FEATURE by making sure we always choose the right ref #63525
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
ghost
assigned
src/libraries/System.Runtime.Experimental/ref/System.Runtime.Experimental.csproj
Outdated
Show resolved
Hide resolved
This was referenced Jan 10, 2022
tannergooding
approved these changes
Jan 10, 2022
|
Failures are linked and known. Change approved offline. |
safern
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #62840
Customer Impact
With the current file version approach, every servicing release we produce of the ref assembly pack will cause
System.Runtime.dllto have a higher file version than the one we ship inSystem.Runtime.Experimentalpackage, causing assembly conflict resolution to prefer the ref assembly that ships inbox as part of the targeting pack, causing compile errors to users when upgrade to a new SDK like:By upgrading the min version of the file version we ensure that it is always greater as now the file version for the experimental one will be 6.100.x.x vs the one inbox will be 6.0.x.x
Testing
I tested with the sample repro by referencing a new package produced locally with the fix and the compiler errors go away. Also visually validated via a binlog that the right
System.Runtime.dllis chosen as a reference when compiling.Risk
Low, we are just changing the assembly file version scheme to make sure it is always greater for the current SDK band.