-
Notifications
You must be signed in to change notification settings - Fork 5.2k
[wasm] Initial templates implementation #63683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[wasm] Initial templates implementation #63683
Conversation
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
To have package version with product version suffix, like `7.0.0-ci`.
Maybe we should start with CommonJS version for the console, until we resolve #62740 |
Console.WriteLine ("Hello, Console!"); | ||
|
||
public class MyClass { | ||
[MethodImpl(MethodImplOptions.NoInlining)] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need this NoInlining
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess its purpose is to avoid inlining the method during AOT. Not sure whether anything changed recently in that area though. @lewing, do you know if we need it?
Can you add documentation about how is this supposed to be used ? |
Co-authored-by: Marek Fišera <[email protected]>
I can add section to the src/mono/wasm/README.md about it. Or do you have some other place in mind? |
Sounds like good start. It might be worth also adding something to the nuget itself |
Also * add README with hint how to run the app * use top level statement to be consistent with browser template
Context: #64232
Add 2 simple WebAssembly templates,
wasmbrowser
andwasmconsole
.The templates are packed into the nuget package, which is added to the
wasm-tools
workload manifest. When the workload is installed, the templates can be used withdotnet new
command.Add build tests to exercise the use of the templates - create, build and publish browser and console projects.