[release/6.0] Fix OpenSSL version check in GetAlpnSupport #64032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
The previous check failed 3.0.0 because the Minor was 0 and Build was 0. It could probably be rewritten to be `>= new Version(1, 0, 2)`, but that'd require more thinking.
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
bartonjs
approved these changes
Jan 20, 2022
bartonjs
added
area-System.Net.Security
Servicing-consider
|
Tagging subscribers to this area: @dotnet/ncl, @vcsjones Issue DetailsBackport of #64023 to release/6.0 /cc @bartonjs Customer ImpactNone. This is a test-only change to make tests correctly behave on systems with OpenSSL 3 installed. TestingTests were run with this change on a system with OpenSSL 3. RiskTest-only change.
|
stephentoub
approved these changes
Jan 20, 2022
danmoseley
removed
the
Servicing-consider
|
Test only changes do not need servicing-consider process. @safern can merge when branch is ready. |
karelz
approved these changes
Feb 1, 2022
|
Failure is unrelated. |
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64023 to release/6.0
/cc @bartonjs
Fixes #63624
Customer Impact
None. This is a test-only change to make tests correctly behave on systems with OpenSSL 3 installed.
Testing
Tests were run with this change on a system with OpenSSL 3.
Risk
Test-only change.