[release/6.0] Fix profiling objectsallocatedbyclass (#63814) #64284
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add test for ObjectsAllocatedByClass profiler callbacks * Fix ObjectsAllocatedByClass profiler callbacks based on wrong flag * Fix wrong args in test log Co-authored-by: Olivier Giniaux <[email protected]>
ghost
added
the
|
Tagging subscribers to this area: @tommcdon Issue DetailsBackport of #63814 to release/6.0 /cc @ogxd A 6.0 PR introduced a regression in the profiling APIs, where the ObjectsAllocatedByClass API was triggered by the wrong profiler keyword. Customer ImpactAs it stands in 6.0 profilers cannot enable ObjectsAllocatedByClass without enabling object allocation callbacks, which is extremely expensive, perturbs the process, and is impossible to do on attach. TestingManual and automated tests RiskLow, the fix is targeted to just the ObjectsAllocatedByClass API.
|
jeffschwMSFT
approved these changes
Jan 25, 2022
jeffschwMSFT
added
the
Servicing-consider
jeffschwMSFT
changed the title
leecow
added
Servicing-approved
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #63814 to release/6.0
/cc @ogxd
A 6.0 PR introduced a regression in the profiling APIs, where the ObjectsAllocatedByClass API was triggered by the wrong profiler keyword.
Customer Impact
As it stands in 6.0 profilers cannot enable ObjectsAllocatedByClass without enabling object allocation callbacks, which is extremely expensive, perturbs the process, and is impossible to do on attach.
Testing
Manual and automated tests
Risk
Low, the fix is targeted to just the ObjectsAllocatedByClass API.