[release/6.0] [mobile] Add extra HttpClientHandler linker substitution #64852
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
The linker substitution for HttpClientHandler.IsNativeHandlerEnabled only worked when <UseNativeHttpHandler> in a project was set to false. Since the default for MAUI projects is true, this caused us to carry more assemblies than needed. Fixes #64361
…mobile.xml Co-authored-by: Eric Erhardt <[email protected]>
ghost
added
the
linkable-framework
|
Tagging subscribers to 'linkable-framework': @eerhardt, @vitek-karas, @LakshanF, @sbomer, @joperezr Issue DetailsBackport of #64818 to release/6.0 /cc @steveisok Customer ImpactTestingRisk
|
steveisok
added
Servicing-approved
|
Approved by tactics over email. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64818 to release/6.0
/cc @steveisok
Customer Impact
The default MAUI app does not use SocketsHttpHandler by default, but due to a missing linker substitution will still carry related assemblies. This results in an app that carries an extra 1MB more than it should.
To fix, we an additional linker substitution when the
<UseNativeHttpHandler>setting is true.Testing
Manually verified the correct assemblies were being trimmed.
Risk
Very low