[release/6.0] [Mono] Fix potential crash when handling image load event. #64911
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
steveisok
added
Servicing-approved
|
Approved by tactics over email. |
|
@steveisok ping me if you need merge and you've gotten an approval. |
|
@safern - this is good to go. Please merge when you can. |
steveisok
approved these changes
Feb 7, 2022
This was referenced Feb 8, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #64908 to release/6.0
/cc @steveisok @lateralusX
Customer Impact
When running
dotnet traceagainst a MAUI application targeting Android, a runtime crash would occur when loader events (image/assembly load/unload) were included. The crash occurred due to Mono.Android assembly no longer including a debug directory entry on a release build. As a result, the runtime had a field that was uninitialized and would lead to the crash.The fix makes sure the struct always gets initialized and that we explicitly set that field (module_il_pdb_path) to an empty string if assembly doesn't include a debug directory entry.
Testing
Manual validation
Risk
Low