Fix RegionInfo creation when using LOCALE_CUSTOM_UNSPECIFIED LCID #64927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @dotnet/area-system-globalization Issue DetailsFixes #64893 Don't allow creating RegionInfo when using LOCALE_CUSTOM_UNSPECIFIED (0x1000) Lcid.
|
safern
reviewed
Feb 9, 2022
src/libraries/System.Globalization/tests/System/Globalization/RegionInfoTests.cs
Outdated
Show resolved
Hide resolved
safern
reviewed
Feb 9, 2022
src/libraries/System.Private.CoreLib/src/System/Globalization/RegionInfo.cs
Show resolved
Hide resolved
…RegionInfoTests.cs Co-authored-by: Santiago Fernandez Madero <[email protected]>
safern
approved these changes
Feb 9, 2022
|
The CI runtime failure in Linux arm is tracked by the issue #65115. |
stephentoub
reviewed
Feb 10, 2022
src/libraries/System.Private.CoreLib/src/System/Globalization/CultureData.Windows.cs
Show resolved
Hide resolved
stephentoub
reviewed
Feb 10, 2022
src/libraries/System.Globalization/tests/System/Globalization/RegionInfoTests.cs
Outdated
Show resolved
Hide resolved
stephentoub
approved these changes
Feb 10, 2022
canton7
reviewed
Feb 10, 2022
| { | ||
| Debug.Assert(!GlobalizationMode.Invariant); | ||
|
|
||
| // LOCALE_CUSTOM_UNSPECIFIED ia an unspecified custom locale, used to identify all supplemental locales. |
ghost
locked as resolved and limited conversation to collaborators
ericstj
added
breaking-change
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #64893
Don't allow creating RegionInfo when using LOCALE_CUSTOM_UNSPECIFIED (0x1000) Lcid.