Skip to content

Conversation

wfurt
Copy link
Member

@wfurt wfurt commented Feb 8, 2022

fixes #64943
I did not any real hangs. But since LOT of tests failing, the run takes very long time ~ 17 minutes on my repro machine.

The most problematic are tests expecting failures. However since we fail to even send something in many cases we basically wait 4 minutes for each failing test.

This change has two parts:
When we expect failure, ignore only Authentication exceptions. That will raise Win32Exception and fail the test in cases we even fail so send something.

It drops PassingTestTimeoutMilliseconds to 1 minute. Since we generally use it to time box single SSL it is still plenty but still much less than original value.

With this failed runs takes ~ 7 minutes and it should finish in CI.

Better platform detection and failure avoidance comes from #64923.

cc: @safern we should take this to 6.0 if we ever back-port the 2022 queue.

@wfurt wfurt added area-System.Net.Security test-enhancement Improvements of test source code labels Feb 8, 2022
@wfurt wfurt requested a review from a team February 8, 2022 05:28
@wfurt wfurt self-assigned this Feb 8, 2022
@ghost
Copy link

ghost commented Feb 8, 2022

Tagging subscribers to this area: @dotnet/ncl, @vcsjones
See info in area-owners.md if you want to be subscribed.

Issue Details

fixes #64943
I did not any real hangs. But since LOT of tests failing, the run takes very long time ~ 17 minutes on my repro machine.

The most problematic are tests expecting failures. However since we fail to even send something in many cases we basically wait 4 minutes for each failing test.

This change has two parts:
When we expect failure, ignore only Authentication exceptions. That will raise Win32Exception and fail the test in cases we even fail so send something.

It drops PassingTestTimeoutMilliseconds to 1 minute. Since we generally use it to time box single SSL it is still plenty but still much less than original value.

With this failed runs takes ~ 7 minutes and it should finish in CI.

Better platform detection and failure avoidance comes from #64923.

cc: @safern we should take this to 6.0 if we ever back-port the 2022 queue.

Author: wfurt
Assignees: wfurt
Labels:

area-System.Net.Security, test enhancement

Milestone: -

@wfurt
Copy link
Member Author

wfurt commented Feb 8, 2022

Failing macOS tests are #64963

Copy link
Member

@CarnaViire CarnaViire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@safern
Copy link
Member

safern commented Feb 8, 2022

cc: @safern we should take this to 6.0 if we ever back-port the 2022 queue.

We already did. So maybe we should get the backport going.

@safern
Copy link
Member

safern commented Feb 8, 2022

/backport to release/6.0

@github-actions
Copy link
Contributor

github-actions bot commented Feb 8, 2022

Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1814810434

@wfurt
Copy link
Member Author

wfurt commented Feb 8, 2022

sounds good @safern. There is more. I'll initiate the backports as they get into main to stabilize the S2022 runs.

@wfurt
Copy link
Member Author

wfurt commented Feb 9, 2022

all the test failures looks like infrastructure issues.

@wfurt wfurt merged commit da2df7e into dotnet:main Feb 9, 2022
@wfurt wfurt deleted the sslTestRun branch February 9, 2022 02:07
@ghost ghost locked as resolved and limited conversation to collaborators Mar 11, 2022
@karelz karelz modified the milestones: 7.0.0, 6.0.x Apr 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.Net.Security test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Net.Security.Tests timing out
6 participants