[mono] Fix support for calls to static virtual methods from gshared c… #65126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vargaz
requested review from
lambdageek,
SamMonoRT and
imhameed
as code owners
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
…ode. Fixes dotnet#65002. When called from gshared code, these methods cannot be resolved at compile time, since they depend on the constrained class which is only known at runtime. * For calls from normal gshared code, load the method address from the rgctx. * For calls from gsharedvt code, extend the existing mono_gsharedvt_constrained_call () JIT icall to be able to handle static virtual methods.
vargaz
force-pushed
the
gshared-static-virtual
branch
from
3ad2d47 to
77a8ffa
Compare
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
This makes sense to me, at a high level. Is there anything special that needs to be done for bitcode, or FullAOT+interp? |
|
bitcode is handled by one of the if cases, interp support should be automatic. |
lambdageek
approved these changes
Feb 10, 2022
This was referenced Feb 10, 2022
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ode.
Fixes #65002.
When called from gshared code, these methods cannot be resolved at compile time,
since they depend on the constrained class which is only known at runtime.
JIT icall to be able to handle static virtual methods.