[mono][s390x] Fix OP_FCONV_TO_I and OP_RCONV_TO_I #65185
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* OP_[FR]CONV_TO_I should result in an 8-byte integer
uweigand
requested review from
SamMonoRT,
imhameed,
lambdageek and
vargaz
as code owners
ghost
added
community-contribution
vargaz
approved these changes
Feb 11, 2022
lambdageek
approved these changes
Feb 11, 2022
|
Looks like this test is now also failing in the 6.0 branch, so once this PR is merged, it should also go into the branch. Hope we can get the CI green again soon ... |
|
/backport to release/6.0 |
|
Started backporting to release/6.0: https://github.com/dotnet/runtime/actions/runs/1843155563 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CC @lambdageek @vargaz @nealef
Fix another fallout of the new test cases added by #64234 on s390x, this time related to float-to-signed-int conversions. As opposed to #64618, this is just a simple back-end bug. For some reason, this only showed up in the CI builder, not on my own machine.