Skip to content

Conversation

adamsitnik
Copy link
Member

The bug reported in #65254 has been fixed by @tmds in #60214. Let's just add a test that ensures that it's not coming back

@adamsitnik adamsitnik added area-System.IO test-enhancement Improvements of test source code labels Feb 14, 2022
@adamsitnik adamsitnik added this to the 7.0.0 milestone Feb 14, 2022
@ghost ghost assigned adamsitnik Feb 14, 2022
@ghost
Copy link

ghost commented Feb 14, 2022

Tagging subscribers to this area: @dotnet/area-system-io
See info in area-owners.md if you want to be subscribed.

Issue Details

The bug reported in #65254 has been fixed by @tmds in #60214. Let's just add a test that ensures that it's not coming back

Author: adamsitnik
Assignees: -
Labels:

area-System.IO, test enhancement

Milestone: 7.0.0

@tmds
Copy link
Member

tmds commented Feb 14, 2022

Let's just add a test that ensures that it's not coming back

fyi #60214 includes a test that verifies a failed stat doesn't throw, and gives the user an expected set of properties. That test already existed prior to the PR, but it was broken.

@danmoseley
Copy link
Member

Should this close #65254?

@adamsitnik
Copy link
Member Author

Should this close #65254?

Not for now, I need to figure out the impact of the bug and whether we should backport the fix to 6.0

@adamsitnik adamsitnik merged commit 848d083 into dotnet:main Feb 14, 2022
@adamsitnik adamsitnik deleted the issue65254 branch February 14, 2022 14:50
@ghost ghost locked as resolved and limited conversation to collaborators Mar 16, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-System.IO test-enhancement Improvements of test source code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants