Fix XNodeReaderFunctionalTests #65500

krwq · 2022-02-17T11:53:09Z

This has started failing after merging: #65290 and blocking all outerloop runs - seems like different project was also using modified APIs in a slightly weird way so fixing those.

ghost · 2022-02-17T11:53:19Z

Tagging subscribers to this area: @dotnet/area-system-xml
See info in area-owners.md if you want to be subscribed.

Issue Details

Fixes: #65416

This has started failing after merging: #65290 - seems like different project was also using modified APIs in a slightly weird way so fixing those.

Author:	krwq
Assignees:	-
Labels:	`area-System.Xml`
Milestone:	-

krwq · 2022-02-17T11:53:35Z

/azp list

krwq · 2022-02-17T11:54:09Z

/azp run runtime-libraries-coreclr outerloop

azure-pipelines · 2022-02-17T11:54:23Z

Azure Pipelines successfully started running 1 pipeline(s).

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs

krwq · 2022-02-17T17:26:10Z

@dotnet/dnceng I'm seeing one of the legs (runtime-libraries-coreclr outerloop (Libraries Build windows x86 Release)) failing which says that .packages\microsoft.dotnet.helix.sdk\7.0.0-beta.22114.7\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(78,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Xml.Linq.xNodeReader.Tests in job f7ad6ba3-1b76-4e4a-9585-727971bce31f has failed. Failure log: https://helix.dot.net/api/2019-06-17/jobs/f7ad6ba3-1b76-4e4a-9585-727971bce31f/workitems/System.Xml.Linq.xNodeReader.Tests/console failed

but the log looks like it passed:

Console log: 'System.Xml.Linq.xNodeReader.Tests' from job f7ad6ba3-1b76-4e4a-9585-727971bce31f workitem 01bd81fd-00b7-4d36-959c-c987a578793c (windows.10.amd64.server19h1.es.open.rt) executed on machine a002RB4

C:\h\w\B3ED0981\w\ABB10929\e>taskkill.exe /f /im corerun.exe 
ERROR: no se encontr� el proceso "corerun.exe".

C:\h\w\B3ED0981\w\ABB10929\e>call RunTests.cmd --runtime-path C:\h\w\B3ED0981\p 
----- start 17/02/2022 13:29:29,70 ===============  To repro directly: ===================================================== 
pushd C:\h\w\B3ED0981\w\ABB10929\e\
"C:\h\w\B3ED0981\p\dotnet.exe" exec --runtimeconfig System.Xml.Linq.xNodeReader.Tests.runtimeconfig.json --depsfile System.Xml.Linq.xNodeReader.Tests.deps.json xunit.console.dll System.Xml.Linq.xNodeReader.Tests.dll -xml testResults.xml -nologo -nocolor -trait category=OuterLoop -notrait category=IgnoreForCI -notrait category=failing 
popd
===========================================================================================================

C:\h\w\B3ED0981\w\ABB10929\e>"C:\h\w\B3ED0981\p\dotnet.exe" exec --runtimeconfig System.Xml.Linq.xNodeReader.Tests.runtimeconfig.json --depsfile System.Xml.Linq.xNodeReader.Tests.deps.json xunit.console.dll System.Xml.Linq.xNodeReader.Tests.dll -xml testResults.xml -nologo -nocolor -trait category=OuterLoop -notrait category=IgnoreForCI -notrait category=failing  
  Discovering: System.Xml.Linq.xNodeReader.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Xml.Linq.xNodeReader.Tests (found 1 of 21 test case)
  Starting:    System.Xml.Linq.xNodeReader.Tests (parallel test collections = on, max threads = 2)
TestCase:XNodeReader - XLinq XNodeReader Tests
Pass:580, Fail:0, Skip:0
  Finished:    System.Xml.Linq.xNodeReader.Tests
=== TEST EXECUTION SUMMARY ===
   System.Xml.Linq.xNodeReader.Tests  Total: 1, Errors: 0, Failed: 0, Skipped: 0, Time: 1,335s
----- end 17/02/2022 13:29:31,58 ----- exit code 0 ----------------------------------------------------------
2022-02-17T13:29:32.083Z	INFO   	run.py	run(48)	main	Beginning reading of test results.
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(48)	get_log_files	Searching 'C:\h\w\B3ED0981\w\ABB10929\e\..' for log files
Found log 'C:\h\w\B3ED0981\w\ABB10929\e\..\console.43dce694.log'
Uri 'https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-65500-merge-f7ad6ba31b764e4a95/System.Xml.Linq.xNodeReader.Tests.Attempt.3/console.43dce694.log?sv=2019-07-07&se=2022-03-09T13%3A19%3A32Z&sr=c&sp=rl&sig=u1mIcWMkXA2%2BE6mba2BVr%2BwNxCH5LsnFMzQ%2FfNGPbB8%3D'
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(66)	construct_log_list	Generated log list: console.43dce694.log:
  https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-65500-merge-f7ad6ba31b764e4a95/System.Xml.Linq.xNodeReader.Tests.Attempt.3/console.43dce694.log?sv=2019-07-07&se=2022-03-09T13%3A19%3A32Z&sr=c&sp=rl&sig=u1mIcWMkXA2%2BE6mba2BVr%2BwNxCH5LsnFMzQ%2FfNGPbB8%3D

2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(90)	read_results	Searching 'C:\h\w\B3ED0981\w\ABB10929\e' for test results files
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(96)	read_results	Found results file C:\h\w\B3ED0981\w\ABB10929\e\testResults.xml with format xunit
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(90)	read_results	Searching 'C:\h\w\B3ED0981\w\ABB10929\uploads' for test results files
2022-02-17T13:29:32.083Z	INFO   	run.py	packing_test_reporter(30)	report_results	Packing 1 test reports to 'C:\h\w\B3ED0981\w\ABB10929\e\__test_report.json'
2022-02-17T13:29:32.083Z	INFO   	run.py	packing_test_reporter(33)	report_results	Packed 1992 bytes

any clues?

danmoseley · 2022-02-17T18:27:25Z

@krwq how did I not see this when I ran tests locally - is this outerloop? (there seems almost zero xml outerloops and it's possible I only ran innerloop)

MattGal · 2022-02-17T18:29:31Z

@dotnet/dnceng I'm seeing one of the legs (runtime-libraries-coreclr outerloop (Libraries Build windows x86 Release)) failing which says that .packages\microsoft.dotnet.helix.sdk\7.0.0-beta.22114.7\tools\Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(78,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item System.Xml.Linq.xNodeReader.Tests in job f7ad6ba3-1b76-4e4a-9585-727971bce31f has failed. Failure log: https://helix.dot.net/api/2019-06-17/jobs/f7ad6ba3-1b76-4e4a-9585-727971bce31f/workitems/System.Xml.Linq.xNodeReader.Tests/console failed

but the log looks like it passed:

Console log: 'System.Xml.Linq.xNodeReader.Tests' from job f7ad6ba3-1b76-4e4a-9585-727971bce31f workitem 01bd81fd-00b7-4d36-959c-c987a578793c (windows.10.amd64.server19h1.es.open.rt) executed on machine a002RB4

C:\h\w\B3ED0981\w\ABB10929\e>taskkill.exe /f /im corerun.exe 
ERROR: no se encontr� el proceso "corerun.exe".

C:\h\w\B3ED0981\w\ABB10929\e>call RunTests.cmd --runtime-path C:\h\w\B3ED0981\p 
----- start 17/02/2022 13:29:29,70 ===============  To repro directly: ===================================================== 
pushd C:\h\w\B3ED0981\w\ABB10929\e\
"C:\h\w\B3ED0981\p\dotnet.exe" exec --runtimeconfig System.Xml.Linq.xNodeReader.Tests.runtimeconfig.json --depsfile System.Xml.Linq.xNodeReader.Tests.deps.json xunit.console.dll System.Xml.Linq.xNodeReader.Tests.dll -xml testResults.xml -nologo -nocolor -trait category=OuterLoop -notrait category=IgnoreForCI -notrait category=failing 
popd
===========================================================================================================

C:\h\w\B3ED0981\w\ABB10929\e>"C:\h\w\B3ED0981\p\dotnet.exe" exec --runtimeconfig System.Xml.Linq.xNodeReader.Tests.runtimeconfig.json --depsfile System.Xml.Linq.xNodeReader.Tests.deps.json xunit.console.dll System.Xml.Linq.xNodeReader.Tests.dll -xml testResults.xml -nologo -nocolor -trait category=OuterLoop -notrait category=IgnoreForCI -notrait category=failing  
  Discovering: System.Xml.Linq.xNodeReader.Tests (method display = ClassAndMethod, method display options = None)
  Discovered:  System.Xml.Linq.xNodeReader.Tests (found 1 of 21 test case)
  Starting:    System.Xml.Linq.xNodeReader.Tests (parallel test collections = on, max threads = 2)
TestCase:XNodeReader - XLinq XNodeReader Tests
Pass:580, Fail:0, Skip:0
  Finished:    System.Xml.Linq.xNodeReader.Tests
=== TEST EXECUTION SUMMARY ===
   System.Xml.Linq.xNodeReader.Tests  Total: 1, Errors: 0, Failed: 0, Skipped: 0, Time: 1,335s
----- end 17/02/2022 13:29:31,58 ----- exit code 0 ----------------------------------------------------------
2022-02-17T13:29:32.083Z	INFO   	run.py	run(48)	main	Beginning reading of test results.
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(48)	get_log_files	Searching 'C:\h\w\B3ED0981\w\ABB10929\e\..' for log files
Found log 'C:\h\w\B3ED0981\w\ABB10929\e\..\console.43dce694.log'
Uri 'https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-65500-merge-f7ad6ba31b764e4a95/System.Xml.Linq.xNodeReader.Tests.Attempt.3/console.43dce694.log?sv=2019-07-07&se=2022-03-09T13%3A19%3A32Z&sr=c&sp=rl&sig=u1mIcWMkXA2%2BE6mba2BVr%2BwNxCH5LsnFMzQ%2FfNGPbB8%3D'
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(66)	construct_log_list	Generated log list: console.43dce694.log:
  https://helixre8s23ayyeko0k025g8.blob.core.windows.net/dotnet-runtime-refs-pull-65500-merge-f7ad6ba31b764e4a95/System.Xml.Linq.xNodeReader.Tests.Attempt.3/console.43dce694.log?sv=2019-07-07&se=2022-03-09T13%3A19%3A32Z&sr=c&sp=rl&sig=u1mIcWMkXA2%2BE6mba2BVr%2BwNxCH5LsnFMzQ%2FfNGPbB8%3D

2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(90)	read_results	Searching 'C:\h\w\B3ED0981\w\ABB10929\e' for test results files
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(96)	read_results	Found results file C:\h\w\B3ED0981\w\ABB10929\e\testResults.xml with format xunit
2022-02-17T13:29:32.083Z	INFO   	run.py	__init__(90)	read_results	Searching 'C:\h\w\B3ED0981\w\ABB10929\uploads' for test results files
2022-02-17T13:29:32.083Z	INFO   	run.py	packing_test_reporter(30)	report_results	Packing 1 test reports to 'C:\h\w\B3ED0981\w\ABB10929\e\__test_report.json'
2022-02-17T13:29:32.083Z	INFO   	run.py	packing_test_reporter(33)	report_results	Packed 1992 bytes

any clues?

Taking a look, I believe there were some reported issues around AzDO reporting APIs failing which would be in the outer log from this console log.

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs

MattGal · 2022-02-17T18:35:07Z

@krwq this is some kind of transient outage in AzDO, already tracked by https://github.com/dotnet/core-eng/issues/15619

You can see this yourself in the below Kusto query for future investigation.
Error message:

msrest.exceptions.ClientRequestError: Error occurred in request., ConnectionError: HTTPSConnectionPool(host='dev.azure.com', port=443): Max retries exceeded with url: /dnceng/public/_apis/test/Runs/45016580/Results (Caused by NewConnectionError('<urllib3.connection.VerifiedHTTPSConnection object at 0x015FA640>: Failed to establish a new connection: [WinError 10060] Se produjo un error durante el intento de conexi�n ya que la parte conectada no respondi� adecuadamente tras un periodo de tiempo, o bien se produjo un error en la conexi�n establecida ya que el host conectado no ha podido responder'))

Logs
| where WorkItemName == "01bd81fd-00b7-4d36-959c-c987a578793c"

Since this is flakiness in an external API all we can really do is create a ticket to investigate the above outages, but they definitely don't seem to be 100% repro so just retrying should unblock you.

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs

danmoseley

with comments. thanks for fixing!

krwq · 2022-02-17T19:13:57Z

@krwq how did I not see this when I ran tests locally - is this outerloop? (there seems almost zero xml outerloops and it's possible I only ran innerloop)

@danmoseley I think it's because it's in System.Private.Xml.Linq not System.Private.Xml, unless you did the full run then perhaps something is working differently on how we do the runs locally than on CI; I've run the reported project with /p:Outerloop=true

danmoseley · 2022-02-17T20:23:53Z

@danmoseley I think it's because it's in System.Private.Xml.Linq not System.Private.Xml, unless you did the full run then perhaps something is working differently on how we do the runs locally than on CI; I've run the reported project with /p:Outerloop=true

That's it then. Intuitively, I did not expect Outerloop to be particularly relevant to Xml..

Fix XNodeReaderFunctionalTests

d21422d

krwq requested review from eiriktsarpalis, danmoseley and layomia February 17, 2022 11:53

ghost added the area-System.Xml label Feb 17, 2022

ghost assigned krwq Feb 17, 2022

This comment was marked as off-topic.

Sign in to view

eiriktsarpalis reviewed Feb 17, 2022

View reviewed changes

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs Show resolved Hide resolved

eiriktsarpalis approved these changes Feb 17, 2022

View reviewed changes

runfoapp bot mentioned this pull request Feb 17, 2022

System.Runtime.Serialization.Xml.Tests failed #59926

Closed

danmoseley reviewed Feb 17, 2022

View reviewed changes

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs Outdated Show resolved Hide resolved

danmoseley reviewed Feb 17, 2022

View reviewed changes

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs Outdated Show resolved Hide resolved

danmoseley reviewed Feb 17, 2022

View reviewed changes

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs Outdated Show resolved Hide resolved

danmoseley reviewed Feb 17, 2022

View reviewed changes

src/libraries/System.Private.Xml.Linq/tests/XDocument.Common/BridgeHelpers.cs Outdated Show resolved Hide resolved

danmoseley approved these changes Feb 17, 2022

View reviewed changes

krwq added 2 commits February 17, 2022 20:38

cleanup Flush/Dispose

86d482d

cleanup few more flushes

6b35274

krwq merged commit cc649ac into dotnet:main Feb 18, 2022

ghost locked as resolved and limited conversation to collaborators Mar 20, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix XNodeReaderFunctionalTests #65500

Fix XNodeReaderFunctionalTests #65500

Uh oh!

krwq commented Feb 17, 2022 •

edited

Loading

Uh oh!

ghost commented Feb 17, 2022

Uh oh!

krwq commented Feb 17, 2022

Uh oh!

This comment was marked as off-topic.

krwq commented Feb 17, 2022

Uh oh!

azure-pipelines bot commented Feb 17, 2022

Uh oh!

Uh oh!

krwq commented Feb 17, 2022

Uh oh!

danmoseley commented Feb 17, 2022

Uh oh!

MattGal commented Feb 17, 2022

Uh oh!

Uh oh!

Uh oh!

MattGal commented Feb 17, 2022

Uh oh!

Uh oh!

Uh oh!

danmoseley left a comment

Uh oh!

krwq commented Feb 17, 2022

Uh oh!

danmoseley commented Feb 17, 2022

Uh oh!

Uh oh!

Fix XNodeReaderFunctionalTests #65500

Fix XNodeReaderFunctionalTests #65500

Uh oh!

Conversation

krwq commented Feb 17, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Feb 17, 2022

Uh oh!

krwq commented Feb 17, 2022

Uh oh!

This comment was marked as off-topic.

krwq commented Feb 17, 2022

Uh oh!

azure-pipelines bot commented Feb 17, 2022

Uh oh!

Uh oh!

krwq commented Feb 17, 2022

Uh oh!

danmoseley commented Feb 17, 2022

Uh oh!

MattGal commented Feb 17, 2022

Uh oh!

Uh oh!

Uh oh!

MattGal commented Feb 17, 2022

Uh oh!

Uh oh!

Uh oh!

danmoseley left a comment

Choose a reason for hiding this comment

Uh oh!

krwq commented Feb 17, 2022

Uh oh!

danmoseley commented Feb 17, 2022

Uh oh!

Uh oh!

krwq commented Feb 17, 2022 •

edited

Loading