-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Revert "[release/6.0] Fix ReadyToRun loading on Apple Silicon (#64104)" #65794
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 8f7dff3.
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved.
/backport to release/6.0-vs4mac |
Started backporting to release/6.0-vs4mac: https://github.com/dotnet/runtime/actions/runs/1890342817 |
@ericstj an error occurred while backporting to release/6.0-vs4mac, please check the run log for details! Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/6.0-vs4mac and backport/pr-65794-to-release/6.0-vs4mac"} |
This didn't need to be backported since the change it reverts was never in release/6.0-vs4mac |
Hi @mangod9, I'm the author of the commit that got reverted. Could you tell me more about the diagnostic failures? I would love to help solve them! |
@hoyosjs can provide details. The issue is that with R2R enabled debuggers are unable to set a breakpoint in R2R code on M1. |
Hello @jgiannuzzi, thanks for reaching out and all the help with R2R on M1. You can see a bit more of the discussion on #65341. Sorry we had to revert this all of a sudden and we forgot to ping you... The bug that resulted from this meant that debugging any app would crash on startup as the framework itself is crossgened. We are trying to get this fixed ASAP to enable m1 r2r :) I am happy to discuss more on the issue I linked. |
This reverts commit to enable R2R for MacOS arm64. It appears to be causing some diagnostics failures which are being investigated. We will reapply the original fix once those are resolved.