Skip to content

Conversation

mangod9
Copy link
Member

@mangod9 mangod9 commented Feb 23, 2022

This reverts commit to enable R2R for MacOS arm64. It appears to be causing some diagnostics failures which are being investigated. We will reapply the original fix once those are resolved.

@ghost
Copy link

ghost commented Feb 23, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

Copy link
Member

@jeffschwMSFT jeffschwMSFT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@jeffschwMSFT jeffschwMSFT merged commit 48e7d76 into release/6.0 Feb 23, 2022
@ericstj
Copy link
Member

ericstj commented Feb 23, 2022

/backport to release/6.0-vs4mac

@github-actions
Copy link
Contributor

Started backporting to release/6.0-vs4mac: https://github.com/dotnet/runtime/actions/runs/1890342817

@github-actions
Copy link
Contributor

@ericstj an error occurred while backporting to release/6.0-vs4mac, please check the run log for details!

Validation Failed: {"resource":"PullRequest","code":"custom","message":"No commits between release/6.0-vs4mac and backport/pr-65794-to-release/6.0-vs4mac"}

@akoeplinger akoeplinger deleted the revert_r2rmacos branch February 24, 2022 12:50
@ericstj
Copy link
Member

ericstj commented Feb 28, 2022

This didn't need to be backported since the change it reverts was never in release/6.0-vs4mac

@jgiannuzzi
Copy link
Contributor

Hi @mangod9, I'm the author of the commit that got reverted. Could you tell me more about the diagnostic failures? I would love to help solve them!

@mangod9
Copy link
Member Author

mangod9 commented Mar 11, 2022

@hoyosjs can provide details. The issue is that with R2R enabled debuggers are unable to set a breakpoint in R2R code on M1.

@hoyosjs
Copy link
Member

hoyosjs commented Mar 11, 2022

Hello @jgiannuzzi, thanks for reaching out and all the help with R2R on M1. You can see a bit more of the discussion on #65341. Sorry we had to revert this all of a sudden and we forgot to ping you... The bug that resulted from this meant that debugging any app would crash on startup as the framework itself is crossgened. We are trying to get this fixed ASAP to enable m1 r2r :) I am happy to discuss more on the issue I linked.

@ghost ghost locked as resolved and limited conversation to collaborators Apr 11, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants