Update the StubManager for better debugger stepping. #65947

AaronRobinsonMSFT · 2022-02-28T04:28:47Z

The StubManager is now aware of InstantiatingMethods in IL Stub and StubLink scenarios.

Created the concept of a "StepThroughStub". This handles cases where the stub should be treated as an implementation detail and forward to the appropriate target.

Updates to various logging statements.

Fixes #63199
Fixes #38777

/cc @noahfalk @jkotas @jkoritzinsky @hoyosjs

and StubLink scenarios Created the concept of a "StepThroughStub". This handles cases where the stub should be treated like as an implementation details and simply forward to the appropriate target. Updates to various logging mechanisms.

ghost · 2022-02-28T04:28:57Z

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

Issue Details

The StubManager is now aware of InstantiatingMethods in IL Stub and StubLink scenarios.

Created the concept of a "StepThroughStub". This handles cases where the stub should be treated like as an implementation detail and forward to the appropriate target.

Updates to various logging statements.

Fixes #63199
Fixes #38777

/cc @noahfalk @jkotas @jkoritzinsky @hoyosjs

Author:	AaronRobinsonMSFT
Assignees:	-
Labels:	`area-Diagnostics-coreclr`
Milestone:	7.0.0

src/coreclr/vm/ilstubcache.cpp

src/coreclr/vm/dynamicmethod.cpp

noahfalk

Thanks a bunch for cleaning this all up 👍
I had a few suggestions and I am curious to see after with the enum change Jan was suggesting but I think it looks pretty good regardless.

src/coreclr/debug/ee/amd64/amd64walker.cpp

src/coreclr/debug/ee/controller.cpp

src/coreclr/vm/stublink.cpp

src/coreclr/vm/stublink.h

src/coreclr/vm/stublink.cpp

src/coreclr/vm/stubmgr.cpp

…esolver.

noahfalk · 2022-03-01T21:54:14Z

cc @mikem8361 @dotnet/dotnet-diag

src/coreclr/vm/method.hpp

src/coreclr/vm/stublink.h

src/coreclr/vm/method.hpp

src/coreclr/vm/stublink.h

Move CODE_SIZE_ALIGN to compilation unit.

AaronRobinsonMSFT · 2022-03-02T07:26:58Z

The ARM64 issue is related to writing to executable memory. I know the fix, but I'd like to make it make sense with the existing Stub and StubLinker API.

For others, this issue looks like the following from the macOS's Console. The failing instruction is attempting to write back a pointer into the Stub and upon stepping over that instruction the OS tears down the corerun process.

System Integrity Protection: enabled

Crashed Thread:        0  Dispatch queue: com.apple.main-thread

Exception Type:        EXC_BAD_ACCESS (SIGBUS)
Exception Codes:       KERN_PROTECTION_FAILURE at 0x00000002800940c0
Exception Codes:       0x0000000000000002, 0x00000002800940c0
Exception Note:        EXC_CORPSE_NOTIFY

Termination Reason:    Namespace SIGNAL, Code 10 Bus error: 10
Terminating Process:   exc handler [34828]

VM Region Info: 0x2800940c0 is in 0x280094000-0x280098000;  bytes after start: 192  bytes before end: 16191
      REGION TYPE                    START - END         [ VSIZE] PRT/MAX SHRMOD  REGION DETAIL
      VM_ALLOCATE                 280070000-280094000    [  144K] rw-/rwx SM=ZER  
--->  VM_ALLOCATE                 280094000-280098000    [   16K] rwx/rwx SM=ZER  
      VM_ALLOCATE                 280098000-2800a0000    [   32K] ---/rwx SM=ZER  

Thread 0 Crashed::  Dispatch queue: com.apple.main-thread
0   libcoreclr.dylib              	       0x1047548ac Stub::SetInstantiatedMethodDesc(MethodDesc*) + 72 (stublink.h:569)
1   libcoreclr.dylib              	       0x104754888 Stub::SetInstantiatedMethodDesc(MethodDesc*) + 36 (stublink.h:568)
2   libcoreclr.dylib              	       0x104754648 MakeUnboxingStubWorker(MethodDesc*) + 700 (prestub.cpp:1682)

/cc @dotnet/interop-contrib as an FYI.

AaronRobinsonMSFT · 2022-03-02T19:20:03Z

Failures are #66100

noahfalk

LGTM!

src/coreclr/vm/method.hpp

Missed flag for CALLI not being a PInvoke.

AaronRobinsonMSFT · 2022-03-03T21:56:00Z

Failures are #66143

AaronRobinsonMSFT added 2 commits February 27, 2022 20:21

Update various comments and logging

f9d2ad3

AaronRobinsonMSFT added the area-Diagnostics-coreclr label Feb 28, 2022

AaronRobinsonMSFT added this to the 7.0.0 milestone Feb 28, 2022

ghost assigned AaronRobinsonMSFT Feb 28, 2022

AaronRobinsonMSFT changed the title ~~Update the StubManager for better debugging stepping.~~ Update the StubManager for better debugger stepping. Feb 28, 2022

jkotas reviewed Feb 28, 2022

View reviewed changes

src/coreclr/vm/ilstubcache.cpp Outdated Show resolved Hide resolved

AaronRobinsonMSFT added 2 commits February 28, 2022 11:47

Updates to comments and logging.

e24a783

ArrayOp IL Stubs no longer marked as nomdStepThroughStub.

319a40c

AaronRobinsonMSFT marked this pull request as ready for review February 28, 2022 19:49

jkotas reviewed Feb 28, 2022

View reviewed changes

src/coreclr/vm/dynamicmethod.cpp Outdated Show resolved Hide resolved

noahfalk approved these changes Mar 1, 2022

View reviewed changes

Reorganize the ILStubType logic between DynamicMethodDesc and ILStubR…

d41e0dd

…esolver.

Review feedback.

32ab9ea

AaronRobinsonMSFT commented Mar 2, 2022

View reviewed changes

src/coreclr/vm/method.hpp Outdated Show resolved Hide resolved

src/coreclr/vm/stublink.h Outdated Show resolved Hide resolved

Apply suggestions from code review

3beeb05

jkotas reviewed Mar 2, 2022

View reviewed changes

src/coreclr/vm/method.hpp Outdated Show resolved Hide resolved

jkotas reviewed Mar 2, 2022

View reviewed changes

src/coreclr/vm/method.hpp Outdated Show resolved Hide resolved

hoyosjs reviewed Mar 2, 2022

View reviewed changes

src/coreclr/vm/stublink.h Outdated Show resolved Hide resolved

AaronRobinsonMSFT added 2 commits March 1, 2022 18:54

Remove FlagUnbreakable flag.

76cc6ab

Move CODE_SIZE_ALIGN to compilation unit.

Fix GCC failure.

466bbc0

Follow the W^X logic for stub generation.

6eb3cf3

This was referenced Mar 2, 2022

profiler.elt work item test failures in slowpatheltenter #60018

Closed

system.reflection.tests.nullabilityinfocontexttests.nullablepubliconlyothertypestest #66100

Closed

Merge remote-tracking branch 'upstream/main' into step_into_stubs

c9c2aca

noahfalk approved these changes Mar 3, 2022

View reviewed changes

src/coreclr/vm/method.hpp Outdated Show resolved Hide resolved

src/coreclr/vm/method.hpp Outdated Show resolved Hide resolved

AaronRobinsonMSFT added 2 commits March 3, 2022 11:09

Use canonical method names for MethodDesc types.

4a80151

Missed flag for CALLI not being a PInvoke.

Merge remote-tracking branch 'upstream/main' into step_into_stubs

e6ef2e4

AaronRobinsonMSFT merged commit c8eeba7 into dotnet:main Mar 4, 2022

AaronRobinsonMSFT deleted the step_into_stubs branch March 4, 2022 01:10

ghost locked as resolved and limited conversation to collaborators Apr 3, 2022

Update the StubManager for better debugger stepping. #65947

Update the StubManager for better debugger stepping. #65947

Uh oh!

Conversation

AaronRobinsonMSFT commented Feb 28, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Feb 28, 2022

Uh oh!

Uh oh!

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

noahfalk commented Mar 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Mar 2, 2022

Uh oh!

AaronRobinsonMSFT commented Mar 2, 2022

Uh oh!

noahfalk left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Mar 3, 2022

Uh oh!

Uh oh!

AaronRobinsonMSFT commented Feb 28, 2022 •

edited

Loading