Skip to content

[PERF][MAUI] Add ios-arm64 logic to create .ipa for perf runs #66159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

akoeplinger
Copy link
Member

Switches from simulator builds to device builds so we can track the size for the .ipa.

We generate a dummy codesigning cert and provisioning profile since device builds require that.

@akoeplinger akoeplinger requested a review from LoopedBard3 March 3, 2022 20:16
@ghost
Copy link

ghost commented Mar 3, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost assigned akoeplinger Mar 3, 2022
Switches from simulator builds to device builds so we can track the size for the .ipa.

We generate a dummy codesigning cert and provisioning profile since device builds require that.
Comment on lines +163 to +167
# remove net6.0-maccatalyst to work around https://github.com/dotnet/sdk/issues/21877
cp MauiTesting.csproj MauiTesting.csproj.bak
sed -i'' -e 's/net6.0-ios;net6.0-maccatalyst/net6.0-ios/g' MauiTesting.csproj

../dotnet publish -bl:MauiiOS.binlog -f net6.0-ios --self-contained -r ios-arm64 -c Release /p:_RequireCodeSigning=false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of using sed, I think you can use a couple different commands mentioned here: dotnet/sdk#21877 (comment)

> dotnet restore
> dotnet build --no-restore -p:BuildIpa=true ...

They are fixing this, so maybe somewhat soon you won't need to workaround it?

Copy link
Member Author

@akoeplinger akoeplinger Mar 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd prefer not to use dotnet build with some arbitrary properties set since we should really be testing publish here like a regular customer would. We can remove the workaround once we have an SDK with the fix.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On the Android side, I wouldn't even recommend using publish. It basically just copies extra files.

@LoopedBard3
Copy link
Member

@akoeplinger I think we can close this. Changes were merged as a part of #66358

@akoeplinger akoeplinger deleted the ios-perf branch March 10, 2022 22:03
@ghost ghost locked as resolved and limited conversation to collaborators Apr 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants