Add BStrStringMarshaller to source generator
#69213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AaronRobinsonMSFT
added
area-System.Runtime.InteropServices
source-generator
ghost
added
the
|
Note regarding the This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change. |
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsFixes #69021
|
AaronRobinsonMSFT
changed the title
BStrStringMarshaller to source generator
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/StringTests.cs
Outdated
Show resolved
Hide resolved
…rtGenerator.Tests/StringTests.cs Wrong marshalling type.
jkotas
reviewed
May 12, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/BStrStringMarshaller.cs
Outdated
Show resolved
Hide resolved
jkotas
reviewed
May 12, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/BStrStringMarshaller.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/tests/LibraryImportGenerator.Tests/StringTests.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Jan Kotas <[email protected]>
…rtGenerator.Tests/StringTests.cs
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/BStrStringMarshaller.cs
Outdated
Show resolved
Hide resolved
…pServices/Marshalling/BStrStringMarshaller.cs
jkotas
reviewed
May 12, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/BStrStringMarshaller.cs
Outdated
Show resolved
Hide resolved
Update ref assembly.
jkotas
reviewed
May 12, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/BStrStringMarshaller.cs
Outdated
Show resolved
Hide resolved
…pServices/Marshalling/BStrStringMarshaller.cs Co-authored-by: Jan Kotas <[email protected]>
This was referenced May 12, 2022
|
@jkoritzinsky @elinor-fung Please take a look. |
jkoritzinsky
approved these changes
May 19, 2022
elinor-fung
approved these changes
May 20, 2022
...ystem.Private.CoreLib/src/System/Runtime/InteropServices/Marshalling/BStrStringMarshaller.cs
Show resolved
Hide resolved
src/libraries/System.Runtime.InteropServices/ref/System.Runtime.InteropServices.cs
Outdated
Show resolved
Hide resolved
|
Failure is #65448 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #69021
/cc @dotnet/interop-contrib