Update design docs to reflect our new marshaller design from partner feedback #71017
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkoritzinsky
added
area-System.Runtime.InteropServices
source-generator
ghost
assigned
|
Tagging subscribers to this area: @dotnet/interop-contrib Issue DetailsThe interop team has been working on new designs for our source-generated marshallers. Now that we're starting implementation in the runtime of these new marshallers, let's make sure to follow our "write it down" culture so we have a record of why we did what we did for our future selves.
|
docs/design/libraries/LibraryImportGenerator/SpanMarshallers.md
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/StructMarshalling.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Aaron Robinson <[email protected]>
AaronRobinsonMSFT
approved these changes
Jun 22, 2022
elinor-fung
reviewed
Jun 22, 2022
docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md
Outdated
Show resolved
Hide resolved
docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md
Outdated
Show resolved
Hide resolved
elinor-fung
approved these changes
Jun 22, 2022
docs/design/libraries/LibraryImportGenerator/UserTypeMarshallingV2.md
Outdated
Show resolved
Hide resolved
…ngV2.md Co-authored-by: Elinor Fung <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The interop team has been working on new designs for our source-generated marshallers. Now that we're starting implementation in the runtime of these new marshallers, let's make sure to follow our "write it down" culture so we have a record of why we did what we did for our future selves.