Skip to content

Add MaybeNullWhen attribute to IParsable.TryParse / ISpanParsable.TryParse #71381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2022
Merged

Add MaybeNullWhen attribute to IParsable.TryParse / ISpanParsable.TryParse #71381

merged 1 commit into from
Jun 30, 2022

Conversation

meziantou
Copy link
Contributor

Fix #71309

Note: The API is not yet approved, so the PR is still in draft.

@ghost
Copy link

ghost commented Jun 28, 2022

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, to please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@ghost
Copy link

ghost commented Jun 28, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost ghost added the community-contribution Indicates that the PR has been added by a community member label Jun 28, 2022
@meziantou meziantou changed the title Add MaybeNullWhen( attribute to IParsable.TryParse / ISpanParsable.Tr… Add MaybeNullWhen attribute to IParsable.TryParse / ISpanParsable.TryParse Jun 28, 2022
stephentoub
stephentoub approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@stephentoub stephentoub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@stephentoub stephentoub added this to the 7.0.0 milestone Jun 28, 2022
@stephentoub stephentoub marked this pull request as ready for review June 28, 2022 19:11
tannergooding
tannergooding approved these changes Jun 28, 2022
View reviewed changes
Copy link
Member

@tannergooding tannergooding left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM and I'm pretty sure @dotnet/fxdc will just approve. But it is still pending actual approval on that end.

@stephentoub
Copy link
Member

But it is still pending actual approval on that end.

The annotation today is wrong. I don't think this requires a review. We can just fix it.

@tannergooding tannergooding merged commit 7cf661d into dotnet:main Jun 30, 2022
@meziantou meziantou deleted the iparsable-maybenull branch June 30, 2022 20:01
@ghost ghost locked as resolved and limited conversation to collaborators Jul 31, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@stephentoub stephentoub stephentoub approved these changes

@tannergooding tannergooding tannergooding approved these changes

Assignees

No one assigned

Labels

community-contribution Indicates that the PR has been added by a community member

Projects

None yet

Milestone

7.0.0

Development

Successfully merging this pull request may close these issues.

[API Proposal]: Change the nullable annotation of IParsable.TryParse / ISpanParsable.TryParse

3 participants

@meziantou @stephentoub @tannergooding