Skip to content

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Jul 23, 2022

Fixes #64134

Figure out if the test NJulianRuleTest still failing and try investigate more if still failing.

@ghost
Copy link

ghost commented Jul 23, 2022

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@ghost
Copy link

ghost commented Jul 23, 2022

Tagging subscribers to this area: @dotnet/area-system-runtime
See info in area-owners.md if you want to be subscribed.

Issue Details

Figure out if the test NJulianRuleTest still failing and try investigate more if still failing.

#64134

Author: tarekgh
Assignees: tarekgh
Labels:

area-System.Runtime

Milestone: -

@tarekgh tarekgh added this to the 7.0.0 milestone Jul 23, 2022
@tarekgh
Copy link
Member Author

tarekgh commented Jul 25, 2022

@elinor-fung a while ago you have filed the issue #64134 regarding a test failure on arm. @stephentoub thankfully disabled this test during that time. In this PR I have enabled the test to see if it still failing. I am getting a green CI run so the test didn't fail. I am thinking of just merging this PR and watching if the test fails again. What do you think?

@stephentoub
Copy link
Member

/azp list

@azure-pipelines
Copy link

@stephentoub
Copy link
Member

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@tarekgh tarekgh marked this pull request as ready for review July 25, 2022 16:24
@tarekgh
Copy link
Member Author

tarekgh commented Jul 25, 2022

The test didn't fail even with the runtime-extra-platforms added leg. I am going to merge this and wait to see if we get this failure again.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System.Tests.TimeZoneInfoTests.NJulianRuleTest crashing on Linux arm
3 participants