[wasm] marshling call to assembly entrypoint via new interop #73156

pavelsavara · 2022-08-01T14:38:24Z

added JavaScriptExports.CallEntrypoint replacing legacy mono_bind_assembly_entry_point
moved legacy imports and split RuntimeHelpers
simplified dotnet-legacy.d.ts
set_arg_type on manually written JavaScriptExports calls

…d_assembly_entry_point` - moved legacy imports and split `RuntimeHelpers`

ghost · 2022-08-01T14:38:53Z

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

added JavaScriptExports.CallEntrypoint replacing legacy mono_bind_assembly_entry_point
moved legacy imports and split RuntimeHelpers

Author:	pavelsavara
Assignees:	pavelsavara
Labels:	`arch-wasm`, `area-System.Runtime.InteropServices.JavaScript`
Milestone:	7.0.0

pavelsavara · 2022-08-01T14:39:00Z

/azp run runtime-wasm

azure-pipelines · 2022-08-01T14:39:10Z

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts: # src/mono/wasm/runtime/imports.ts # src/mono/wasm/runtime/startup.ts

...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

src/mono/wasm/runtime/managed-exports.ts

src/mono/wasm/runtime/run.ts

…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Co-authored-by: Katelyn Gadd <[email protected]>

pavelsavara · 2022-08-03T10:00:21Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T10:00:35Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-08-03T13:41:49Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T13:42:05Z

Azure Pipelines successfully started running 1 pipeline(s).

Issue: dotnet#73312

Issue: dotnet#71887

pavelsavara · 2022-08-03T20:08:56Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T20:09:15Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-08-03T21:47:09Z

/azp run runtime-wasm

azure-pipelines · 2022-08-03T21:47:17Z

Azure Pipelines successfully started running 1 pipeline(s).

# Conflicts: # src/mono/wasm/runtime/dotnet.d.ts # src/mono/wasm/runtime/exports.ts # src/mono/wasm/runtime/imports.ts # src/mono/wasm/runtime/managed-exports.ts # src/mono/wasm/runtime/net6-legacy/method-calls.ts # src/mono/wasm/runtime/startup.ts

...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs

…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Co-authored-by: Marek Fišera <[email protected]>

pavelsavara · 2022-08-04T07:53:04Z

/azp run runtime-wasm

azure-pipelines · 2022-08-04T07:53:12Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-08-04T07:58:57Z

/azp run runtime-wasm

azure-pipelines · 2022-08-04T07:59:07Z

Azure Pipelines successfully started running 1 pipeline(s).

pavelsavara · 2022-08-04T10:51:44Z

WebAssembly.Browser.HotReload.Test
"MONO_WASM: onConfigLoaded() failed: {}"

is #73330 fix should be #73366

System.Text.Json.Tests
System.NotSupportedException : The deserialization constructor for type 'System.Tuple`1[System.Int32]' contains parameters with null names.

is #73347

Debugger failures are #73342

lewing · 2022-08-14T22:24:37Z

for 8 we should consider emitting a Task<int> wrapper directly.

- added JavaScriptExports.CallEntrypoint replacing legacy `mono_bin…

46e620c

…d_assembly_entry_point` - moved legacy imports and split `RuntimeHelpers`

pavelsavara added arch-wasm WebAssembly architecture area-System.Runtime.InteropServices.JavaScript labels Aug 1, 2022

pavelsavara added this to the 7.0.0 milestone Aug 1, 2022

pavelsavara requested review from kg and maraf August 1, 2022 14:38

pavelsavara self-assigned this Aug 1, 2022

pavelsavara added 3 commits August 1, 2022 20:28

wip

f3d1373

Merge branch 'main' into wasm_drop_legacy_entrypoint

e7ea896

Merge branch 'main' into wasm_drop_legacy_entrypoint

378fd4e

# Conflicts: # src/mono/wasm/runtime/imports.ts # src/mono/wasm/runtime/startup.ts

kg reviewed Aug 2, 2022

View reviewed changes

...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Show resolved Hide resolved

kg reviewed Aug 2, 2022

View reviewed changes

...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Outdated Show resolved Hide resolved

kg reviewed Aug 3, 2022

View reviewed changes

...rvices.JavaScript/src/System/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Show resolved Hide resolved

kg reviewed Aug 3, 2022

View reviewed changes

src/mono/wasm/runtime/managed-exports.ts Outdated Show resolved Hide resolved

kg reviewed Aug 3, 2022

View reviewed changes

src/mono/wasm/runtime/run.ts Outdated Show resolved Hide resolved

pavelsavara and others added 3 commits August 3, 2022 11:41

Merge branch 'main' into wasm_drop_legacy_entrypoint

2a85dd4

Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…

27f232b

…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Co-authored-by: Katelyn Gadd <[email protected]>

feedback

0a2156f

pavelsavara added 2 commits August 3, 2022 13:55

fix

2d9068e

fix

bb4d41b

[wasm] Fix Wasm.Build.Tests builds

b26c856

Issue: dotnet#73312

pavelsavara mentioned this pull request Aug 3, 2022

[wasm] reduce legacy interop usage #72021

Merged

[wasm] Disable failing Wasm.Build.Tests test on windows

b487be6

Issue: dotnet#71887

pavelsavara added 2 commits August 3, 2022 22:08

Merge branch 'main' into wasm_drop_legacy_entrypoint

cb4ea99

Merge branch 'wbt-green' into wasm_drop_legacy_entrypoint

ab01424

pavelsavara marked this pull request as ready for review August 3, 2022 21:44

pavelsavara requested review from radical and lewing as code owners August 3, 2022 21:44

Merge branch 'main' into wasm_drop_legacy_entrypoint

3a90cdf

maraf approved these changes Aug 4, 2022

View reviewed changes

pavelsavara and others added 4 commits August 4, 2022 09:47

types cleanup

d6c8330

Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…

f1a77d3

…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Co-authored-by: Marek Fišera <[email protected]>

Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…

3763a30

…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Co-authored-by: Marek Fišera <[email protected]>

Update src/libraries/System.Runtime.InteropServices.JavaScript/src/Sy…

00f8f08

…stem/Runtime/InteropServices/JavaScript/Interop/JavaScriptExports.cs Co-authored-by: Marek Fišera <[email protected]>

feedback

b950b9f

pavelsavara merged commit 44cb67e into dotnet:main Aug 4, 2022

ghost locked as resolved and limited conversation to collaborators Sep 14, 2022

pavelsavara deleted the wasm_drop_legacy_entrypoint branch November 29, 2022 16:22

[wasm] marshling call to assembly entrypoint via new interop #73156

[wasm] marshling call to assembly entrypoint via new interop #73156

Uh oh!

Conversation

pavelsavara commented Aug 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Aug 1, 2022

Uh oh!

pavelsavara commented Aug 1, 2022

Uh oh!

azure-pipelines bot commented Aug 1, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Aug 3, 2022

Uh oh!

azure-pipelines bot commented Aug 3, 2022

Uh oh!

pavelsavara commented Aug 3, 2022

Uh oh!

azure-pipelines bot commented Aug 3, 2022

Uh oh!

pavelsavara commented Aug 3, 2022

Uh oh!

azure-pipelines bot commented Aug 3, 2022

Uh oh!

pavelsavara commented Aug 3, 2022

Uh oh!

azure-pipelines bot commented Aug 3, 2022

Uh oh!

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Aug 4, 2022

Uh oh!

azure-pipelines bot commented Aug 4, 2022

Uh oh!

pavelsavara commented Aug 4, 2022

Uh oh!

azure-pipelines bot commented Aug 4, 2022

Uh oh!

pavelsavara commented Aug 4, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lewing commented Aug 14, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

pavelsavara commented Aug 1, 2022 •

edited

Loading

pavelsavara commented Aug 4, 2022 •

edited

Loading

lewing commented Aug 14, 2022 •

edited

Loading