Skip to content

Guard Kerberos test with RemoteExecutor.IsSupported #73362

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Guard Kerberos test with RemoteExecutor.IsSupported #73362

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0bd0bf
Guard Kerberos test with RemoteExecutor.IsSupported
filipnavara Aug 4, 2022
1fcf8e8
Fix cleanup in error cases, capture GSSAPI trace for errors
filipnavara Aug 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 31 additions & 8 deletions src/libraries/Common/tests/System/Net/Security/Kerberos/KerberosExecutor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,10 @@
using System.Collections.Generic;
using System.IO;
using System.Linq;
using System.Security.Cryptography;
using System.Text;
using System.Threading.Tasks;
using Kerberos.NET.Configuration;
using Kerberos.NET.Crypto;
using Kerberos.NET.Entities;
using Kerberos.NET.Server;
using Kerberos.NET.Logging;
using Xunit.Abstractions;
Expand All @@ -26,9 +24,12 @@ public class KerberosExecutor : IDisposable
private RemoteInvokeHandle? _invokeHandle;
private string? _krb5Path;
private string? _keytabPath;
private string? _tracePath;
private readonly List<FakeKerberosPrincipal> _servicePrincipals;
private readonly ITestOutputHelper _testOutputHelper;

public static bool IsSupported { get; } = OperatingSystem.IsLinux() || OperatingSystem.IsMacOS();
public static bool IsSupported { get; } =
RemoteExecutor.IsSupported && (OperatingSystem.IsLinux() || OperatingSystem.IsMacOS());

public const string DefaultAdminPassword = "PLACEHOLDERadmin.";

Expand All @@ -47,7 +48,6 @@ public KerberosExecutor(ITestOutputHelper testOutputHelper, string realm)
_principalService = new FakePrincipalService(realm);

byte[] krbtgtPassword = new byte[16];
//RandomNumberGenerator.Fill(krbtgtPassword);

var krbtgt = new FakeKerberosPrincipal(PrincipalType.Service, "krbtgt", realm, krbtgtPassword);
_principalService.Add("krbtgt", krbtgt);
Expand All @@ -65,14 +65,34 @@ public KerberosExecutor(ITestOutputHelper testOutputHelper, string realm)
_kdcListener = new FakeKdcServer(_options);
_realm = realm;
_servicePrincipals = new List<FakeKerberosPrincipal>();
_testOutputHelper = testOutputHelper;
}

public void Dispose()
{
_invokeHandle?.Dispose();
_kdcListener.Stop();
File.Delete(_krb5Path);
File.Delete(_keytabPath);
try
{
_invokeHandle?.Dispose();
}
catch (Exception)
{
try
{
_testOutputHelper.WriteLine("GSSAPI trace:");
_testOutputHelper.WriteLine(File.ReadAllText(_tracePath));
}
catch (IOException)
{
}
throw;
}
finally
{
_kdcListener.Stop();
File.Delete(_tracePath);
File.Delete(_krb5Path);
File.Delete(_keytabPath);
}
}

public void AddService(string name, string password = DefaultAdminPassword)
Expand Down Expand Up @@ -136,8 +156,11 @@ private async Task PrepareInvoke()
writer.Flush();
}

_tracePath = Path.GetTempFileName();

// Set environment variables for GSSAPI
Environment.SetEnvironmentVariable("KRB5_CONFIG", _krb5Path);
Environment.SetEnvironmentVariable("KRB5_KTNAME", _keytabPath);
Environment.SetEnvironmentVariable("KRB5_TRACE", _tracePath);
}
}