[release/7.0] [mono] Assert that we don't need to inflate types when applying DIM overrides #74519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
In #64102 (comment) we concluded that this branch is never taken.
github-actions
bot
requested review from
vargaz,
lambdageek and
thaystg
as code owners
ghost
added
the
|
@marek-safar can we get an approval? |
SamMonoRT
approved these changes
Aug 25, 2022
marek-safar
approved these changes
Aug 25, 2022
|
Approved |
|
@lambdageek @SamMonoRT is the mono native failure related to this change, or is this good to merge?
|
|
No, I think the mono llvmfullaot failure is related to #73455 |
|
Ok thanks. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #74379 to release/7.0
/cc @lambdageek
Fixes #70190
Customer Impact
Customer code that depends on generic interfaces with default implementations does not crash.
Testing
CI and manual testing
Risk
Moderate - there is no good workaround if any of the new asserts fail.
IMPORTANT: Is this backport for a servicing release? If so and this change touches code that ships in a NuGet package, please make certain that you have added any necessary package authoring and gotten it explicitly reviewed.