Skip to content

Conversation

directhex
Copy link
Contributor

When called via runtime-extra-platforms, in theory, only smoke tests are run. Full-blown tests should run if individual tests are called (e.g. with /azp run runtime-ios)

Closes: #75002

When called via runtime-extra-platforms, in theory, only smoke tests are run.
Full-blown tests should run if individual tests are called (e.g. with
`/azp run runtime-ios`)

Closes: dotnet#75002
@ghost ghost assigned directhex Sep 7, 2022
@ghost
Copy link

ghost commented Sep 7, 2022

Tagging subscribers to this area: @directhex
See info in area-owners.md if you want to be subscribed.

Issue Details

When called via runtime-extra-platforms, in theory, only smoke tests are run. Full-blown tests should run if individual tests are called (e.g. with /azp run runtime-ios)

Closes: #75002

Author: directhex
Assignees: -
Labels:

area-Infrastructure-mono

Milestone: -

@directhex directhex requested a review from steveisok September 7, 2022 19:33
@directhex directhex changed the base branch from main to joshield/split-runtime-extra-platforms September 9, 2022 13:30
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 9, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 9, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 9, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 9, 2022
@dotnet dotnet deleted a comment from azure-pipelines bot Sep 9, 2022
@directhex
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Sep 12, 2022
@directhex
Copy link
Contributor Author

OK, this seems broadly correct now. Will retarget against main & un-draft in the morning

@directhex directhex changed the base branch from joshield/split-runtime-extra-platforms to main September 16, 2022 13:15
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

/azp run runtime-androidemulator

@dotnet dotnet deleted a comment from azure-pipelines bot Sep 27, 2022
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok
Copy link
Member

nit: Should we move the special pipelines into its own folder?

@directhex
Copy link
Contributor Author

Do we want to deal with assorted nits now, or get it in & worry about the other stuff later?

We need to go through an extended process for this, as we need to modify all the new AzDO jobs to point to main etc instead of only the special test branch they currently point at

@steveisok
Copy link
Member

Do we want to deal with assorted nits now, or get it in & worry about the other stuff later?

We need to go through an extended process for this, as we need to modify all the new AzDO jobs to point to main etc instead of only the special test branch they currently point at

I wasn't sure if it was desirable or not. Certainly ok in a follow up if it makes sense.

@radical
Copy link
Member

radical commented Sep 28, 2022

The top level ymls, the ones that azdo pipelines point to, should remain in eng/pipelines. And the rest which are all templates can be moved to more appropriate folders. This wouldn't need any changes in azdo side either, and IIUC, follows the existing convention (except where I violated that, and will now fix ;).

@radical
Copy link
Member

radical commented Sep 28, 2022

Have you already tried invoking all the pipelines? Not to run them to completion, but to just check that there aren't any yml issues.

@directhex
Copy link
Contributor Author

/azp run runtime-android

@directhex
Copy link
Contributor Author

/azp run runtime-ioslike

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

/azp run runtime-linuxbionic

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

1 similar comment
@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

/azp run runtime-ioslikesimulator

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@radical
Copy link
Member

radical commented Sep 28, 2022

Looks like the 4 started up without any issues.

@directhex
Copy link
Contributor Author

/azp run runtime-extra-platforms

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@directhex
Copy link
Contributor Author

/azp run runtime-maccatalyst

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@steveisok steveisok merged commit 74f23f1 into dotnet:joshield/split-runtime-extra-platforms Sep 28, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more granular pipelines for mobile configurations
3 participants