Skip to content

[wasm-mt] Additional build fixes #75297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2022
Merged

[wasm-mt] Additional build fixes #75297

merged 1 commit into from
Sep 12, 2022

Conversation

lambdageek
Copy link
Member

Foward port changes from release/7.0 #75171 that were not included in main #75162

  • when building the InteropServices.JavaScript library, enable threading if MonoWasmBuildVariant is set appropriately. One consequence is that the runtime will (correctly) install the browser synchronization context on the main thread.

  • for workload build testing, unset MonoWasmBuildVariant when creating the non-threaded runtime

@lambdageek
[wasm-mt] Additional build fixes
a28164c 
Foward port changes from `release/7.0` dotnet#75171
that were not included in `main` dotnet#75162

- when building the InteropServices.JavaScript library, enable
threading if MonoWasmBuildVariant is set appropriately.  One
consequence is that the runtime will (correctly) install the browser
synchronization context on the main thread.

- for workload build testing, unset MonoWasmBuildVariant when creating
the non-threaded runtime
@ghost ghost assigned lambdageek Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

Issue Details

Foward port changes from release/7.0 #75171 that were not included in main #75162

  • when building the InteropServices.JavaScript library, enable threading if MonoWasmBuildVariant is set appropriately. One consequence is that the runtime will (correctly) install the browser synchronization context on the main thread.

  • for workload build testing, unset MonoWasmBuildVariant when creating the non-threaded runtime

Author: lambdageek
Assignees: -
Labels:

area-Infrastructure-libraries
Milestone: -

@lambdageek lambdageek added arch-wasm WebAssembly architecture and removed area-Infrastructure-libraries labels Sep 8, 2022
@ghost
Copy link

ghost commented Sep 8, 2022

Tagging subscribers to 'arch-wasm': @lewing
See info in area-owners.md if you want to be subscribed.

Issue Details

Foward port changes from release/7.0 #75171 that were not included in main #75162

  • when building the InteropServices.JavaScript library, enable threading if MonoWasmBuildVariant is set appropriately. One consequence is that the runtime will (correctly) install the browser synchronization context on the main thread.

  • for workload build testing, unset MonoWasmBuildVariant when creating the non-threaded runtime

Author: lambdageek
Assignees: lambdageek
Labels:

arch-wasm, area-Build-mono
Milestone: -

@lambdageek lambdageek requested a review from radical September 8, 2022 19:15
@lambdageek
Copy link
Member Author

Linux llvmaot failure is not related - this PR is only changing the wasm build

@lambdageek lambdageek merged commit ac092cf into dotnet:main Sep 12, 2022
@ghost ghost locked as resolved and limited conversation to collaborators Oct 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@radical radical radical approved these changes

@lewing lewing lewing approved these changes

@pavelsavara pavelsavara Awaiting requested review from pavelsavara pavelsavara is a code owner

Assignees

@lambdageek lambdageek

Labels

arch-wasm WebAssembly architecture area-Build-mono

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lambdageek @radical @lewing